From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3C8C433ED for ; Thu, 29 Apr 2021 15:37:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15FAE61418 for ; Thu, 29 Apr 2021 15:37:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15FAE61418 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5602F6EE5C; Thu, 29 Apr 2021 15:37:46 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 726FF6EE5C for ; Thu, 29 Apr 2021 15:37:45 +0000 (UTC) IronPort-SDR: /1BZpCxzr68XHb7wTREYq25TudFM/lbjAW3ebpzRI91/qD8/DEHmT7fI2s/upJuPe5WDmb8ykB oPO9rgN+zgAQ== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="196592699" X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="196592699" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 08:37:44 -0700 IronPort-SDR: kYljJPkZABznCQiJZg2loZbnwvw+++ojQ3wLn9VSpAWh6YBv8DSoV/c6mdJNrgwjJpMaS/+lmO FwG7Img59c8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="426048771" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga007.jf.intel.com with SMTP; 29 Apr 2021 08:37:42 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 29 Apr 2021 18:37:41 +0300 Date: Thu, 29 Apr 2021 18:37:41 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: <20210429023535.1653-1-ville.syrjala@linux.intel.com> <87r1it33yq.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87r1it33yq.fsf@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cooper Chiou , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Apr 29, 2021 at 11:11:25AM +0300, Jani Nikula wrote: > On Thu, 29 Apr 2021, Ville Syrjala wrote: > > From: Ville Syrj=E4l=E4 > > > > We lost the i915_reg_rw tracepoint for a lot of display registers > > when we switched from the heavyweight normal register accessors to > > the lightweight _fw() variants. > = > Sorry, which change was that exactly? commit dd584fc0711a ("drm/i915: Use I915_READ_FW for plane updates") and probably a few others like it. > = > > Put the tracepoints back so that > > the register traces might actually be useful. Hopefully these should > > be close to free when the tracepoint is not enabled and thus not > > slow down our vblank critical sections significantly. > > > > The biggest hurdle is untangling the include order. Fortunately just > > pulling intel_de.h out from intel_display_types.h seems to have been > > sufficient to make it build. > = > This is something I've been meaning to fix independently. Thanks. Hmm. Maybe I should split this into two commits... > = > Reviewed-by: Jani Nikula Ta. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx