From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888E8C433B4 for ; Tue, 11 May 2021 14:53:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23A14613C1 for ; Tue, 11 May 2021 14:53:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23A14613C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 876416EA51; Tue, 11 May 2021 14:53:38 +0000 (UTC) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4709E6EA51 for ; Tue, 11 May 2021 14:53:38 +0000 (UTC) Received: by mail-ej1-x632.google.com with SMTP id s20so24689338ejr.9 for ; Tue, 11 May 2021 07:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LhVK+bnj04xYFvnqTOEUW7faHSNI0VKlzkbYMyncPII=; b=IzlVYRIYH7gAru/gboHgS3sWsK4FQwVQOLSEhGVSDexRUACz0WaOuz1YQCUxluSgkz ypRD97YLv83rv3j8JsR6MUELXTM4+A9kxgOrUz08WJg2dtTDyrnbK8cFgmv8/pfIV9+M r66M4d6LePdX6wC5PgVIcgTZzfbfJrKujyDs8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LhVK+bnj04xYFvnqTOEUW7faHSNI0VKlzkbYMyncPII=; b=mEVen6MLs1SY1DyYvNq2H1CPtzzRtel1jdXgalLGEJb2KTIiZsK9e6a8Iipqnd33yO v0wPYtEWx14KAnQ0J7G5kxBbra06MdmahvwvYyYUF1ug9zCbNFCWOOsmM+84nze6+qu4 kjt2nc7H+zAy6GCKVmwrjvjCE1Y622dyXdj54A5erHN2oj3YaEY/7lfrdmw7s73yhlMM DFMnra+Pb6usxt66hT2UPGXrzsT0PmFulrAx9GlV3ZT4pUdZSp9hEcZzaNM3EbsHqNIo LFAhvA44y7PgyQtZfDQq1nDCTZg/0iEkHfeMcmpYP95LeD2YspPaL2MlWUefovJe1FJO WL2w== X-Gm-Message-State: AOAM533MXYnfPD9+PE74DX72xSJndezKLyspYW06cokYDz7pJvTwhFe1 oW7TO8xRcvjnaZbaIaOrZVawUg== X-Google-Smtp-Source: ABdhPJw/jbsGbMLnyKkU8KorQFUB8dw0NpCDYgRnc8X8zdpqu+gxeLC73fhSOossZ7d4tWl28Qvm9w== X-Received: by 2002:a17:906:ae8f:: with SMTP id md15mr32463857ejb.244.1620744817032; Tue, 11 May 2021 07:53:37 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id w2sm12990145edl.53.2021.05.11.07.53.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 07:53:36 -0700 (PDT) Date: Tue, 11 May 2021 16:53:34 +0200 From: Daniel Vetter To: Matthew Brost Message-ID: References: <20210506173049.72503-1-matthew.brost@intel.com> <20210506173049.72503-4-matthew.brost@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210506173049.72503-4-matthew.brost@intel.com> X-Operating-System: Linux phenom 5.10.32scarlett+ Subject: Re: [Intel-gfx] [RFC PATCH 3/5] drm/i915: Expose logical engine instance to user X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, carl.zhang@intel.com, jason.ekstrand@intel.com, daniel.vetter@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, May 06, 2021 at 10:30:47AM -0700, Matthew Brost wrote: > Expose logical engine instance to user via query engine info IOCTL. This > is required for split-frame workloads as these need to be placed on > engines in a logically contiguous order. The logical mapping can change > based on fusing. Rather than having user have knowledge of the fusing we > simply just expose the logical mapping with the existing query engine > info IOCTL. > > Cc: Tvrtko Ursulin > Cc: Tony Ye > CC: Carl Zhang > Cc: Daniel Vetter > Cc: Jason Ekstrand > Signed-off-by: Matthew Brost > --- > include/uapi/drm/i915_drm.h | 7 ++++++- Two things on all these 3 patches: - Until we've merged the uapi it shouldn't show up in uapi headers. See what Matt A. has done with a fake local header in Documentation/gpu/rfc which you can pull in. - Since this one is tiny I think just the text in the rfc is good enough, I'd drop this. - Squash the others in with the parallel submit rfc patch so that the structs and long-form text are all in one patch please, makes reviewing the overall thing a bit simpler. Rule is to have a complete change per patch, and then not split things further. > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > index 9f331ad629f5..26d2e135aa31 100644 > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -2396,14 +2396,19 @@ struct drm_i915_engine_info { > > /** @flags: Engine flags. */ > __u64 flags; > +#define I915_ENGINE_INFO_HAS_LOGICAL_INSTANCE (1 << 0) > > /** @capabilities: Capabilities of this engine. */ > __u64 capabilities; > #define I915_VIDEO_CLASS_CAPABILITY_HEVC (1 << 0) > #define I915_VIDEO_AND_ENHANCE_CLASS_CAPABILITY_SFC (1 << 1) > > + /** Logical engine instance */ I think in the final version that we merge with the uapi this should: - explain why we need this - link to relevant other uapi like the paralle submit extension Cheers, Daniel > + __u16 logical_instance; > + > /** @rsvd1: Reserved fields. */ > - __u64 rsvd1[4]; > + __u16 rsvd1[3]; > + __u64 rsvd2[3]; > }; > > /** > -- > 2.28.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx