From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45727C47080 for ; Mon, 31 May 2021 14:05:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 075336135C for ; Mon, 31 May 2021 14:05:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 075336135C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8083E89FDE; Mon, 31 May 2021 14:05:43 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id C425C6E4CB for ; Mon, 31 May 2021 14:05:41 +0000 (UTC) IronPort-SDR: zrmKAPSXCk6OUbK2lcsFRlhRlY9cE32lmZu2OkMXDqXw+MqHjKXpfVUsq5rXIMYeZprbGF0Jcn A2P4tvuD543A== X-IronPort-AV: E=McAfee;i="6200,9189,10001"; a="190725843" X-IronPort-AV: E=Sophos;i="5.83,237,1616482800"; d="scan'208";a="190725843" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2021 07:05:40 -0700 IronPort-SDR: 2gRWLD1y+Ii+EvcXgq7PFrcBVBxYV1toOQb7EtbvcXJZvABIDdlN8XkP5CWkeDpqdEpeOjTWCb KkOrIIPoG9Xg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,237,1616482800"; d="scan'208";a="410955140" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga007.fm.intel.com with SMTP; 31 May 2021 07:05:38 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 31 May 2021 17:05:37 +0300 Date: Mon, 31 May 2021 17:05:37 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Sodhi, Vunny" Message-ID: References: <1622460737-46494-1-git-send-email-vunny.sodhi@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1622460737-46494-1-git-send-email-vunny.sodhi@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Add support of MOD_Y_TILED during fb init X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Sodhi@freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, May 31, 2021 at 07:32:17PM +0800, Sodhi, Vunny wrote: > Adding Y_TILED modifier which is needed to support DRM_FORMAT_NV12 > during framebuffer initialization. > = > Signed-off-by: Sodhi, Vunny > --- > drivers/gpu/drm/i915/display/intel_display.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/d= rm/i915/display/intel_display.c > index caf0414..a9b1b62 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -11610,8 +11610,10 @@ static int intel_framebuffer_init(struct intel_f= ramebuffer *intel_fb, > if (tiling =3D=3D I915_TILING_X) { > mode_cmd->modifier[0] =3D I915_FORMAT_MOD_X_TILED; > } else if (tiling =3D=3D I915_TILING_Y) { > + mode_cmd->modifier[0] =3D I915_FORMAT_MOD_Y_TILED; > + } else { This is just the legacy bo tiling->modifier path, which is not needed by any old userspace, and all modern userspace should just use modifiers. > drm_dbg_kms(&dev_priv->drm, > - "No Y tiling for legacy addfb\n"); > + "Unsupported tiling for legacy addfb\n"); > goto err; > } > } > -- = > 2.7.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx