From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E1CC07E95 for ; Fri, 2 Jul 2021 19:16:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C96BC61411 for ; Fri, 2 Jul 2021 19:16:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C96BC61411 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8B5F6E1E6; Fri, 2 Jul 2021 19:16:31 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 628F06E1DE for ; Fri, 2 Jul 2021 19:16:30 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id a13so13640175wrf.10 for ; Fri, 02 Jul 2021 12:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=CJZ66ZHRahf3MuzOHvcbR8txgxK1tXasYSH3KpOnrjo=; b=krMTpEMYXPoslVYQR7vaiA1VkVzU+BBWMNBxhxOyHtRvh8VvTicmBCG5qS78wwshU4 2bsU9axx3nLiFGJBkJWZCCuU1OeIgJN0v7qr5XzGxw9Dm9zjZg8pXeD/opXPVkF9UrIZ bMXLFutb5HfS08RLgSu+9EPZ7DiNbUvvrDcMQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CJZ66ZHRahf3MuzOHvcbR8txgxK1tXasYSH3KpOnrjo=; b=qfg6STykMVh7EfVHzGuLRIYJAPCuvP8nf+0uXDjnYK0vwXaYNLT20uZDP191sB81U2 1GuT0fgSR/R9EO18DJTttwrQjd2+VnHRW8eZtQecEb69iYLaegsQT705aPhmbZsedWpj y2ViaaarPFaxEvAjIOL/mYpTNFHv02Whf8ilOweB4iGxIunZZxORZzFLMnga+NEIy8P/ BCZviiQcyQ96kfz7Hcy2OSMhdf0YYVNFZbzXTDJW2BfLngnS7wGUBT0LmaLXOPzkgdL2 c/aXqtzVZydSg1945Zqmv55BSkmKECdsDqP/GO1wuavm57Q01W+AbK77OpM2+iSOujMt X6TA== X-Gm-Message-State: AOAM530Mu8M3fyn7S9gaTloUL/P6jqQF0tTlX4BKmHiT3VgG0dvUy7yR 4CkC0O1rwYY+HDY+o7934GO9yw== X-Google-Smtp-Source: ABdhPJxL1XTsXjAMpLSxu3+5p0E2TjLqfG3lp5CazxP5eoff1D7H8PkNI+HMgmM3W5xF54/6WVLbIw== X-Received: by 2002:a5d:524e:: with SMTP id k14mr1302458wrc.390.1625253389020; Fri, 02 Jul 2021 12:16:29 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h9sm3802480wmb.35.2021.07.02.12.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 12:16:27 -0700 (PDT) Date: Fri, 2 Jul 2021 21:16:26 +0200 From: Daniel Vetter To: Matthew Auld Message-ID: References: <20210701143650.1094468-1-matthew.auld@intel.com> <20210701143650.1094468-2-matthew.auld@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210701143650.1094468-2-matthew.auld@intel.com> X-Operating-System: Linux phenom 5.10.0-7-amd64 Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915/uapi: reject caching ioctls for discrete X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kenneth Graunke Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jul 01, 2021 at 03:36:49PM +0100, Matthew Auld wrote: > It's a noop on DG1, and in the future when need to support other devices > which let us control the coherency, then it should be an immutable > creation time property for the BO. > = > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Thomas Hellstr=F6m > Cc: Maarten Lankhorst > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Daniel Vetter > Cc: Ramalingam C For this and the next can you pls add kerneldoc for the uapi structs and then add a note there that on dgfx they're disallowed? Same for the next one. At least I'd like if we can document uapi here as we go, so that we have something to point people to when they as "what has changed? what should I do in my userspace driver?". Also please make sure these two have acks from mesa devs before you land them. Thanks, Daniel > --- > drivers/gpu/drm/i915/gem/i915_gem_domain.c | 6 ++++++ > 1 file changed, 6 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c b/drivers/gpu/drm= /i915/gem/i915_gem_domain.c > index 7d1400b13429..43004bef55cb 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c > @@ -268,6 +268,9 @@ int i915_gem_get_caching_ioctl(struct drm_device *dev= , void *data, > struct drm_i915_gem_object *obj; > int err =3D 0; > = > + if (IS_DGFX(to_i915(dev))) > + return -ENODEV; > + > rcu_read_lock(); > obj =3D i915_gem_object_lookup_rcu(file, args->handle); > if (!obj) { > @@ -303,6 +306,9 @@ int i915_gem_set_caching_ioctl(struct drm_device *dev= , void *data, > enum i915_cache_level level; > int ret =3D 0; > = > + if (IS_DGFX(i915)) > + return -ENODEV; > + > switch (args->caching) { > case I915_CACHING_NONE: > level =3D I915_CACHE_NONE; > -- = > 2.26.3 > = -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx