From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E48C4743C for ; Wed, 23 Jun 2021 19:17:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51F6460FF4 for ; Wed, 23 Jun 2021 19:17:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51F6460FF4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F3B726E985; Wed, 23 Jun 2021 19:17:04 +0000 (UTC) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE6616E988 for ; Wed, 23 Jun 2021 19:17:03 +0000 (UTC) Received: by mail-ej1-x635.google.com with SMTP id ji1so5668129ejc.4 for ; Wed, 23 Jun 2021 12:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=7Hua08stsWuHXUQaJW2px47NH816H2YtXOe8cA4IlCg=; b=igrDooVK7zk8zc3g3dng9Z4kKomtb0NBT/xyXoKOS94YQo/bjKuJrZADYBrMzD09nW 8ViG1g+Jg+fDW1mVxTt0V786rlCxik1uVc+AvXawxAIArMsqXfluF3j4zx8Z0vlo9uvD 8Dy525bFR2inG+gm3XXR2dYbhgCibAdYaUrCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7Hua08stsWuHXUQaJW2px47NH816H2YtXOe8cA4IlCg=; b=H0fzR4q7ocvOS1KWHP0VGMvQDKVjA7l1b6uY/vJhW03qedtVQQKRV1X+89bXxDt4+M 0LLlHN/gtm1qbTGosixWeRl+w0pjFgT4wqIq0AhF4ZIiQbN5Jjhdd4zlVSMRkCAuk6DL EiVxHxxzdbBybsLyQsFdY0RZBxkEXRTEsySFXQWNZyeZZkuwhULPmBa6KM2mXs42b1kS zelcMSGYmIZz+ISgZ7rUG9iLeV16luNNdOzTGc1Tc4wDMR6pbSYWdKY7yC16HfppyxI4 /D0NWt0obvFeYOYuo1SYfpRmH8WW+mHxCLG3T1hRQBbQUsgCddeyGxFMT9H3pl4iEsnE UDHA== X-Gm-Message-State: AOAM532/FnDNcva0qGNPmnxFhSL5YYFnL98OpFcw6aMbCcru7vZzJodz JDHh54OT7Im2O4itJYnrIVP4hg== X-Google-Smtp-Source: ABdhPJzJhju7GF3OV5WfqUhYCkKTkqdmd8DF/MurQj6ivLt84BKbGtZA9SzfqW27EuszS2xGxd/K8A== X-Received: by 2002:a17:907:1ca0:: with SMTP id nb32mr1565572ejc.105.1624475822653; Wed, 23 Jun 2021 12:17:02 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id s7sm260735ejd.88.2021.06.23.12.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 12:17:02 -0700 (PDT) Date: Wed, 23 Jun 2021 21:17:00 +0200 From: Daniel Vetter To: Boris Brezillon Message-ID: References: <20210622165511.3169559-1-daniel.vetter@ffwll.ch> <20210622165511.3169559-7-daniel.vetter@ffwll.ch> <20210623184737.7e47f77c@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210623184737.7e47f77c@collabora.com> X-Operating-System: Linux phenom 5.10.0-7-amd64 Subject: Re: [Intel-gfx] [PATCH 06/15] drm/panfrost: Fix implicit sync X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomeu Vizoso , Daniel Vetter , Intel Graphics Development , DRI Development , Steven Price , linaro-mm-sig@lists.linaro.org, Alyssa Rosenzweig , Daniel Vetter , Christian =?iso-8859-1?Q?K=F6nig?= , linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jun 23, 2021 at 06:47:37PM +0200, Boris Brezillon wrote: > On Tue, 22 Jun 2021 18:55:02 +0200 > Daniel Vetter wrote: > = > > Currently this has no practial relevance I think because there's not > > many who can pull off a setup with panfrost and another gpu in the > > same system. But the rules are that if you're setting an exclusive > > fence, indicating a gpu write access in the implicit fencing system, > > then you need to wait for all fences, not just the previous exclusive > > fence. > > = > > panfrost against itself has no problem, because it always sets the > > exclusive fence (but that's probably something that will need to be > > fixed for vulkan and/or multi-engine gpus, or you'll suffer badly). > > Also no problem with that against display. > > = > > With the prep work done to switch over to the dependency helpers this > > is now a oneliner. > > = > > Signed-off-by: Daniel Vetter > > Cc: Rob Herring > > Cc: Tomeu Vizoso > > Cc: Steven Price > > Cc: Alyssa Rosenzweig > > Cc: Sumit Semwal > = > Reviewed-by: Boris Brezillon Pushed the 3 panfrost patches to drm-misc-next, thanks for reviewing them. -Daniel > = > > Cc: "Christian K=F6nig" > > Cc: linux-media@vger.kernel.org > > Cc: linaro-mm-sig@lists.linaro.org > > --- > > drivers/gpu/drm/panfrost/panfrost_job.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > = > > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/= panfrost/panfrost_job.c > > index 71cd43fa1b36..ef004d587dc4 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > > @@ -203,9 +203,8 @@ static int panfrost_acquire_object_fences(struct dr= m_gem_object **bos, > > int i, ret; > > = > > for (i =3D 0; i < bo_count; i++) { > > - struct dma_fence *fence =3D dma_resv_get_excl_unlocked(bos[i]->resv); > > - > > - ret =3D drm_gem_fence_array_add(deps, fence); > > + /* panfrost always uses write mode in its current uapi */ > > + ret =3D drm_gem_fence_array_add_implicit(deps, bos[i], true); > > if (ret) > > return ret; > > } > = -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx