From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0179DC49EA5 for ; Thu, 24 Jun 2021 10:56:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB030613FD for ; Thu, 24 Jun 2021 10:56:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB030613FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D21D6EB5B; Thu, 24 Jun 2021 10:56:21 +0000 (UTC) X-Greylist: delayed 517 seconds by postgrey-1.36 at gabe; Thu, 24 Jun 2021 10:56:19 UTC Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8171F6EB5B for ; Thu, 24 Jun 2021 10:56:19 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 842B9532; Thu, 24 Jun 2021 12:47:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624531659; bh=ZNycYCdpm5oEjlFfF/sEqNXjEFO/n03c+byQ10Bt5bw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CGN9DVFsEHoPFf+pGvo+BS5Oqq8sbq0BRLQS9wPa02YfsZbZHe42KSDL8SiS8nknQ Dlh8v3FIrtFZ+aIelYdI0hq6VcbgqVLgvJq3npv5I27MKCnHAHxEiouigFeN+ZPJ+I gY9uoWeAbXhjpnjIo6lsntNy9MnvXU5it7HqZ5l0= Date: Thu, 24 Jun 2021 13:47:08 +0300 From: Laurent Pinchart To: Thomas Zimmermann Message-ID: References: <20210624072916.27703-1-tzimmermann@suse.de> <20210624072916.27703-17-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210624072916.27703-17-tzimmermann@suse.de> Subject: Re: [Intel-gfx] [PATCH v3 16/27] drm/rcar-du: Don't set struct drm_device.irq_enabled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hamohammed.sa@gmail.com, heiko@sntech.de, emma@anholt.net, airlied@linux.ie, nouveau@lists.freedesktop.org, alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org, michal.simek@xilinx.com, melissa.srw@gmail.com, linux-tegra@vger.kernel.org, thierry.reding@gmail.com, amd-gfx@lists.freedesktop.org, benjamin.gaignard@linaro.org, linux@armlinux.org.uk, mihail.atanassov@arm.com, festevam@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, krzysztof.kozlowski@canonical.com, linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org, wens@csie.org, jernej.skrabec@gmail.com, jonathanh@nvidia.com, xinliang.liu@linaro.org, kong.kongxinwei@hisilicon.com, james.qian.wang@arm.com, linux-imx@nxp.com, intel-gfx@lists.freedesktop.org, linux-graphics-maintainer@vmware.com, linux-sunxi@lists.linux.dev, bskeggs@redhat.com, chunkuang.hu@kernel.org, p.zabel@pengutronix.de, puck.chen@hisilicon.com, s.hauer@pengutronix.de, mripard@kernel.org, inki.dae@samsung.com, rodrigosiqueiramelo@gmail.com, john.stultz@linaro.org, laurentiu.palcu@oss.nxp.com, matthias.bgg@gmail.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com, hyun.kwon@xilinx.com, tomba@kernel.org, jyri.sarha@iki.fi, yannick.fertre@foss.st.com, Xinhui.Pan@amd.com, sw0312.kim@samsung.com, hjc@rock-chips.com, christian.koenig@amd.com, kyungmin.park@samsung.com, kieran.bingham+renesas@ideasonboard.com, philippe.cornu@foss.st.com, alexander.deucher@amd.com, tiantao6@hisilicon.com, shawnguo@kernel.org, zackr@vmware.com, l.stach@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Thomas, Thank you for the patch. On Thu, Jun 24, 2021 at 09:29:05AM +0200, Thomas Zimmermann wrote: > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in rcar-du. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index bfbff90588cb..e289a66594a7 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -593,8 +593,6 @@ static int rcar_du_probe(struct platform_device *pdev) > goto error; > } > > - rcdu->ddev.irq_enabled = 1; > - > /* > * Register the DRM device with the core and the connectors with > * sysfs. -- Regards, Laurent Pinchart _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx