From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93318C49EA6 for ; Thu, 24 Jun 2021 13:32:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AC0660FD9 for ; Thu, 24 Jun 2021 13:32:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AC0660FD9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B79C6EB89; Thu, 24 Jun 2021 13:32:32 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 977D36EB86 for ; Thu, 24 Jun 2021 13:32:30 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id l18-20020a1ced120000b029014c1adff1edso6256258wmh.4 for ; Thu, 24 Jun 2021 06:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=UFhiEJt504RTMqp8+hAmLUOvZwafHba6yxHF1LCXlIs=; b=NApO4BqpqZKbsAPF2q7911aiX0XFllNygyqDwm4IpfIkqxF/qWVA0VnvAuV0FxRdCF 6K5D9Z3plpwX8SDdOqUsJjeJZz/Y5lFX8XUrxROI+89xMLhUqqlzSCrLAPF/HRLjBWE1 T/Ci+swNVAFxxNMtP58pmAxZaM3O3xDFYRElo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=UFhiEJt504RTMqp8+hAmLUOvZwafHba6yxHF1LCXlIs=; b=ew3fuEFVbDGVgB2LrbogKLo8z6EAgxRz+Y7XXnGehVp/P6Ti6a3h754BdwyMdT622y lKYj7ob4opgNHEO0+QKPia3JAiYWw931Xu6oxf7lLvq3S14ZJy3bi+UrVkZ3S7T3Epm8 JaZvaJb1ExNN8ZKMmLBbImkgIJrS1aeTBwxwCS3ymtgPXWZBaj0f7ARnDTdWVNRl6hO8 /1FV/89MrqRsaCycZqGYLg/81xBe2vtZuhr62Dl/b0QQdQvSiatF75XHeUaw3KAwRBe8 xmPrwXG/7Z2Snd1Vrd/Sr+Qc81UG5IX9EFhAD2jhrWZ9sMuHX7QEW8xwI6Hom1z8LGR4 faNQ== X-Gm-Message-State: AOAM530eIIoKMIIamKOcBaFBrM2R8sEMtTC9ID6JEHY6JilLhLYGghdI BsKxcP4G2dFwX2Tz7lHA8h5aNQ== X-Google-Smtp-Source: ABdhPJymDBd9yUGzh0GWCdZP9XBIxJSPvo36dzctTaDRmiC9UV0XJC81gCId6b7YQmM7kwKhDQUcYA== X-Received: by 2002:a7b:cb8d:: with SMTP id m13mr4353165wmi.8.1624541549303; Thu, 24 Jun 2021 06:32:29 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id y4sm3225289wrw.71.2021.06.24.06.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 06:32:28 -0700 (PDT) Date: Thu, 24 Jun 2021 15:32:26 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Message-ID: References: <20210622165511.3169559-1-daniel.vetter@ffwll.ch> <20210622165511.3169559-15-daniel.vetter@ffwll.ch> <4ed8f1d3-eb9c-74d6-d93f-ee28971af7f6@amd.com> <4fba7964-3306-4e2a-f87e-906ebedbe7fe@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4fba7964-3306-4e2a-f87e-906ebedbe7fe@amd.com> X-Operating-System: Linux phenom 5.10.0-7-amd64 Subject: Re: [Intel-gfx] [PATCH 14/15] drm/gem: Tiny kernel clarification for drm_gem_fence_array_add X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development , Maxime Ripard , Daniel Vetter , Lucas Stach Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jun 24, 2021 at 02:48:54PM +0200, Christian K=F6nig wrote: > = > = > Am 24.06.21 um 14:41 schrieb Daniel Vetter: > > On Wed, Jun 23, 2021 at 10:42:50AM +0200, Christian K=F6nig wrote: > > > Am 22.06.21 um 18:55 schrieb Daniel Vetter: > > > > Spotted while trying to convert panfrost to these. > > > > = > > > > Signed-off-by: Daniel Vetter > > > > Cc: "Christian K=F6nig" > > > > Cc: Lucas Stach > > > > Cc: Maarten Lankhorst > > > > Cc: Maxime Ripard > > > > Cc: Thomas Zimmermann > > > > Cc: David Airlie > > > > Cc: Daniel Vetter > > > > --- > > > > drivers/gpu/drm/drm_gem.c | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > = > > > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > > > > index ba2e64ed8b47..68deb1de8235 100644 > > > > --- a/drivers/gpu/drm/drm_gem.c > > > > +++ b/drivers/gpu/drm/drm_gem.c > > > > @@ -1302,6 +1302,9 @@ EXPORT_SYMBOL(drm_gem_unlock_reservations); > > > > * @fence_array: array of dma_fence * for the job to block on. > > > > * @fence: the dma_fence to add to the list of dependencies. > > > > * > > > > + * This functions consumes the reference for @fence both on succes= s and error > > > > + * cases. > > > > + * > > > Oh, the later is a bit ugly I think. But good to know. > > > = > > > Reviewed-by: Christian K=F6nig > > Merged to drm-misc-next, thanks for taking a look. Can you perhaps take= a > > look at the drm/armada patch too, then I think I have reviews/acks for = all > > of them? > = > What are you talking about? I only see drm/armada patches for the irq stu= ff > Thomas is working on. There was one in this series, but Maxime was quicker. I'm going to apply all the remaining ones now. After that I'll send out a patch set to add some dependency tracking to drm_sched_job so that there's not so much copypasta going on there. I stumbled over that when reviewing how we handle dependencies. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx