From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6153C636C9 for ; Wed, 21 Jul 2021 18:56:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A099560FDA for ; Wed, 21 Jul 2021 18:56:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A099560FDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C4586ECFB; Wed, 21 Jul 2021 18:56:55 +0000 (UTC) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC5B86ECFA for ; Wed, 21 Jul 2021 18:56:53 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id w13so1915955wmc.3 for ; Wed, 21 Jul 2021 11:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=dmX+J/TmQQOqSIzmduc+Fl5JJ/RQlTISy6TWURapR34=; b=BrhMZAMH95b1QRGELnHfPW1NcJbOBkvvpt/dkAY8E8mUZCZ9xlV5+VbBzqMn07eNBd cCLCPU8e4hVp9YygCk3W/O5GnRG1TdLV1IbOEj8Tj6GxzrIlit0fIPQ45ou2L164OQp3 TKQPvVCQcDEAH5F98VQDJ/q84VhW+8JPlE+u4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dmX+J/TmQQOqSIzmduc+Fl5JJ/RQlTISy6TWURapR34=; b=TTuH7JA6QeJLpbl2ROY1PEHqxGvzHgTCB0y+YqWWHvkIScYJHvEEwgqSvjjoedjZoj ZB5+HZvu7pR7imsm9HbglxdRq60iBC9wojt8YJAoRUDIxYhLXvTiZmBBYGXVPAShK6I0 oPHHQbLXIrelxdkXmwvL2HCQthb/N4pAqKeraE9+6cPZAEWZyKHh/YXei9K4gBNVJ2+2 hxUuMObw6beCiC4sFr0tyi93/ghk1DoJovwg58UK415intgyFzZVzpMcoZZpVgiIdbkw p5z+OmEJOI8lVKRS71RH3S7BRZe9v2aAwsQeKV/jl7UoNGrljCMYicYau9sken8grgXg 4clg== X-Gm-Message-State: AOAM530CIZUWWBvWEDsZqGcLiY/t4tpXb17DwtULFnAXZnubo6Cz0G8d MDQQ9NmjiWoGB7l2s3KyRJ/z6g== X-Google-Smtp-Source: ABdhPJxASHwoXQZYkUon/KQ+fbRoKgE2XTpj9OEQKGPuQ0di+bFpHjt1Vaue7Pkz7crNqXcf+RYl2Q== X-Received: by 2002:a05:600c:2101:: with SMTP id u1mr5385193wml.55.1626893812551; Wed, 21 Jul 2021 11:56:52 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id d29sm33878690wrb.63.2021.07.21.11.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 11:56:52 -0700 (PDT) Date: Wed, 21 Jul 2021 20:56:50 +0200 From: Daniel Vetter To: Matthew Auld Message-ID: References: <20210721152358.2893314-1-jason@jlekstrand.net> <20210721152358.2893314-7-jason@jlekstrand.net> <23df1788-bd8e-ac44-337d-92bb5f345b8f@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <23df1788-bd8e-ac44-337d-92bb5f345b8f@intel.com> X-Operating-System: Linux phenom 5.10.0-7-amd64 Subject: Re: [Intel-gfx] [PATCH 6/6] drm/i915: Make the kmem slab for i915_buddy_block a global X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jul 21, 2021 at 05:25:41PM +0100, Matthew Auld wrote: > On 21/07/2021 16:23, Jason Ekstrand wrote: > > There's no reason that I can tell why this should be per-i915_buddy_mm > > and doing so causes KMEM_CACHE to throw dmesg warnings because it tries > > to create a debugfs entry with the name i915_buddy_block multiple times. > > We could handle this by carefully giving each slab its own name but that > > brings its own pain because then we have to store that string somewhere > > and manage the lifetimes of the different slabs. The most likely > > outcome would be a global atomic which we increment to get a new name or > > something like that. > > = > > The much easier solution is to use the i915_globals system like we do > > for every other slab in i915. This ensures that we have exactly one of > > them for each i915 driver load and it gets neatly created on module load > > and destroyed on module unload. Using the globals system also means > > that its now tied into the shrink handler so we can properly respond to > > low-memory situations. > > = > > Signed-off-by: Jason Ekstrand > > Fixes: 88be9a0a06b7 ("drm/i915/ttm: add ttm_buddy_man") > > Cc: Matthew Auld > > Cc: Christian K=F6nig > = > It was intentionally ripped it out with the idea that we would be moving = the > buddy stuff into ttm, and so part of that was trying to get rid of the so= me > of the i915 specifics, like this globals thing. > = > Reviewed-by: Matthew Auld I just sent out a patch to put i915_globals on a diet, so maybe we can hold this patch here a bit when there's other reasons for why this is special? Or at least no make this use the i915_globals stuff and instead just link up the init/exit function calls directly into Jason's new table, so that we don't have a merge conflict here? -Daniel > = > > --- > > drivers/gpu/drm/i915/i915_buddy.c | 44 ++++++++++++++++++++++------- > > drivers/gpu/drm/i915/i915_buddy.h | 3 +- > > drivers/gpu/drm/i915/i915_globals.c | 2 ++ > > 3 files changed, 38 insertions(+), 11 deletions(-) > > = > > diff --git a/drivers/gpu/drm/i915/i915_buddy.c b/drivers/gpu/drm/i915/i= 915_buddy.c > > index 29dd7d0310c1f..911feedad4513 100644 > > --- a/drivers/gpu/drm/i915/i915_buddy.c > > +++ b/drivers/gpu/drm/i915/i915_buddy.c > > @@ -8,8 +8,14 @@ > > #include "i915_buddy.h" > > #include "i915_gem.h" > > +#include "i915_globals.h" > > #include "i915_utils.h" > > +static struct i915_global_buddy { > > + struct i915_global base; > > + struct kmem_cache *slab_blocks; > > +} global; > > + > > static struct i915_buddy_block *i915_block_alloc(struct i915_buddy_mm= *mm, > > struct i915_buddy_block *parent, > > unsigned int order, > > @@ -19,7 +25,7 @@ static struct i915_buddy_block *i915_block_alloc(stru= ct i915_buddy_mm *mm, > > GEM_BUG_ON(order > I915_BUDDY_MAX_ORDER); > > - block =3D kmem_cache_zalloc(mm->slab_blocks, GFP_KERNEL); > > + block =3D kmem_cache_zalloc(global.slab_blocks, GFP_KERNEL); > > if (!block) > > return NULL; > > @@ -34,7 +40,7 @@ static struct i915_buddy_block *i915_block_alloc(stru= ct i915_buddy_mm *mm, > > static void i915_block_free(struct i915_buddy_mm *mm, > > struct i915_buddy_block *block) > > { > > - kmem_cache_free(mm->slab_blocks, block); > > + kmem_cache_free(global.slab_blocks, block); > > } > > static void mark_allocated(struct i915_buddy_block *block) > > @@ -85,15 +91,11 @@ int i915_buddy_init(struct i915_buddy_mm *mm, u64 s= ize, u64 chunk_size) > > GEM_BUG_ON(mm->max_order > I915_BUDDY_MAX_ORDER); > > - mm->slab_blocks =3D KMEM_CACHE(i915_buddy_block, SLAB_HWCACHE_ALIGN); > > - if (!mm->slab_blocks) > > - return -ENOMEM; > > - > > mm->free_list =3D kmalloc_array(mm->max_order + 1, > > sizeof(struct list_head), > > GFP_KERNEL); > > if (!mm->free_list) > > - goto out_destroy_slab; > > + return -ENOMEM; > > for (i =3D 0; i <=3D mm->max_order; ++i) > > INIT_LIST_HEAD(&mm->free_list[i]); > > @@ -145,8 +147,6 @@ int i915_buddy_init(struct i915_buddy_mm *mm, u64 s= ize, u64 chunk_size) > > kfree(mm->roots); > > out_free_list: > > kfree(mm->free_list); > > -out_destroy_slab: > > - kmem_cache_destroy(mm->slab_blocks); > > return -ENOMEM; > > } > > @@ -161,7 +161,6 @@ void i915_buddy_fini(struct i915_buddy_mm *mm) > > kfree(mm->roots); > > kfree(mm->free_list); > > - kmem_cache_destroy(mm->slab_blocks); > > } > > static int split_block(struct i915_buddy_mm *mm, > > @@ -410,3 +409,28 @@ int i915_buddy_alloc_range(struct i915_buddy_mm *m= m, > > #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) > > #include "selftests/i915_buddy.c" > > #endif > > + > > +static void i915_global_buddy_shrink(void) > > +{ > > + kmem_cache_shrink(global.slab_blocks); > > +} > > + > > +static void i915_global_buddy_exit(void) > > +{ > > + kmem_cache_destroy(global.slab_blocks); > > +} > > + > > +static struct i915_global_buddy global =3D { { > > + .shrink =3D i915_global_buddy_shrink, > > + .exit =3D i915_global_buddy_exit, > > +} }; > > + > > +int __init i915_global_buddy_init(void) > > +{ > > + global.slab_blocks =3D KMEM_CACHE(i915_buddy_block, 0); > > + if (!global.slab_blocks) > > + return -ENOMEM; > > + > > + i915_global_register(&global.base); > > + return 0; > > +} > > diff --git a/drivers/gpu/drm/i915/i915_buddy.h b/drivers/gpu/drm/i915/i= 915_buddy.h > > index 37f8c42071d12..d8f26706de52f 100644 > > --- a/drivers/gpu/drm/i915/i915_buddy.h > > +++ b/drivers/gpu/drm/i915/i915_buddy.h > > @@ -47,7 +47,6 @@ struct i915_buddy_block { > > * i915_buddy_alloc* and i915_buddy_free* should suffice. > > */ > > struct i915_buddy_mm { > > - struct kmem_cache *slab_blocks; > > /* Maintain a free list for each order. */ > > struct list_head *free_list; > > @@ -130,4 +129,6 @@ void i915_buddy_free(struct i915_buddy_mm *mm, stru= ct i915_buddy_block *block); > > void i915_buddy_free_list(struct i915_buddy_mm *mm, struct list_head = *objects); > > +int i915_global_buddy_init(void); > > + > > #endif > > diff --git a/drivers/gpu/drm/i915/i915_globals.c b/drivers/gpu/drm/i915= /i915_globals.c > > index 87267e1d2ad92..e57102a4c8d16 100644 > > --- a/drivers/gpu/drm/i915/i915_globals.c > > +++ b/drivers/gpu/drm/i915/i915_globals.c > > @@ -8,6 +8,7 @@ > > #include > > #include "i915_active.h" > > +#include "i915_buddy.h" > > #include "gem/i915_gem_context.h" > > #include "gem/i915_gem_object.h" > > #include "i915_globals.h" > > @@ -87,6 +88,7 @@ static void __i915_globals_cleanup(void) > > static __initconst int (* const initfn[])(void) =3D { > > i915_global_active_init, > > + i915_global_buddy_init, > > i915_global_context_init, > > i915_global_gem_context_init, > > i915_global_objects_init, > > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx