From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71754C4338F for ; Wed, 25 Aug 2021 13:43:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25D6660FD8 for ; Wed, 25 Aug 2021 13:43:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 25D6660FD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF6A46E215; Wed, 25 Aug 2021 13:43:41 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB2FD6E215 for ; Wed, 25 Aug 2021 13:43:40 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10086"; a="204658003" X-IronPort-AV: E=Sophos;i="5.84,350,1620716400"; d="scan'208";a="204658003" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2021 06:43:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,350,1620716400"; d="scan'208";a="494269460" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga008.fm.intel.com with SMTP; 25 Aug 2021 06:43:36 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 25 Aug 2021 16:43:35 +0300 Date: Wed, 25 Aug 2021 16:43:35 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Souza, Jose" Cc: "daniel@ffwll.ch" , "Mun, Gwan-gyeong" , "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" , "Vivi, Rodrigo" Message-ID: References: <20210818004216.220279-1-jose.souza@intel.com> <20210818004216.220279-8-jose.souza@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 7/8] drm/i915/display/skl+: Drop frontbuffer rendering support X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Aug 25, 2021 at 03:47:12PM +0300, Ville Syrjälä wrote: > On Wed, Aug 25, 2021 at 12:49:25AM +0000, Souza, Jose wrote: > > On Thu, 2021-08-19 at 19:07 +0300, Ville Syrjälä wrote: > > > On Wed, Aug 18, 2021 at 07:48:03PM +0000, Souza, Jose wrote: > > > > On Wed, 2021-08-18 at 17:55 +0300, Ville Syrjälä wrote: > > > > > On Tue, Aug 17, 2021 at 05:42:15PM -0700, José Roberto de Souza wrote: > > > > > > By now all the userspace applications should have migrated to atomic > > > > > > or at least be calling DRM_IOCTL_MODE_DIRTYFB. > > > > > > > > > > > > With that we can kill frontbuffer rendering support in i915 for > > > > > > modern platforms. > > > > > > > > > > > > So here converting legacy APIs into atomic commits so it can be > > > > > > properly handled by driver i915. > > > > > > > > > > > > Several IGT tests will fail with this changes, because some tests > > > > > > were stressing those frontbuffer rendering scenarios that no userspace > > > > > > should be using by now, fixes to IGT should be sent soon. > > > > > > > > > > Blocking atomic commits instead of the current lightweight frontbuffer > > > > > interface sounds like a terrible plan. How unusable is X with this > > > > > approach? > > > > > > > > 100% usable, had no issues when running X in TGL and ADL-P. > > > > Added a debug message in intel_user_framebuffer_dirty() and X is not even using frontbuffer rendering at all. > > > > > > Turn off your compositor if you want to test front buffer rendering. > > > > Worked fine on Plasma with a 4K panel, was not able to find how to do that in Gnome. > > I didn't think you can turn off composition with either one of those. > You actually confirmed it's running with everytithing unredirected and > eg. there was no lag moving windows around and wiggling the mouse? > > Avoiding that lag is pretty much the sole reason why the legacy > cursor unsynced update stuff even exists in the driver. Hard to > imagine you wouldn't hit the same issue with the server getting > blocked on dirtyfb all the time. Oh and running x11perf/etc. to see the impact on the raw numbers would probably be good idea. -- Ville Syrjälä Intel