From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C99AC432BE for ; Thu, 26 Aug 2021 17:31:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47AD16103C for ; Thu, 26 Aug 2021 17:31:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 47AD16103C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C13336E886; Thu, 26 Aug 2021 17:31:52 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id B688F6E886 for ; Thu, 26 Aug 2021 17:31:51 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10088"; a="278810925" X-IronPort-AV: E=Sophos;i="5.84,354,1620716400"; d="scan'208";a="278810925" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 10:31:51 -0700 X-IronPort-AV: E=Sophos;i="5.84,354,1620716400"; d="scan'208";a="527975968" Received: from fbenmlih-mobile.amr.corp.intel.com (HELO intel.com) ([10.255.36.148]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 10:31:49 -0700 Date: Thu, 26 Aug 2021 13:31:48 -0400 From: Rodrigo Vivi To: Imre Deak Cc: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , "Lee, Shawn C" , "Almahallawy, Khaled" , "intel-gfx@lists.freedesktop.org" , "Chiou, Cooper" , "Tseng, William" Message-ID: References: <20210706152541.25021-1-shawn.c.lee@intel.com> <20210818161712.GA2831921@ideak-desk.fi.intel.com> <20210820230203.GC2886701@ideak-desk.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210820230203.GC2886701@ideak-desk.fi.intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Aug 21, 2021 at 02:02:03AM +0300, Imre Deak wrote: > On Sat, Aug 21, 2021 at 01:20:04AM +0300, Ville Syrjälä wrote: > > On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > > > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > > > On Tue, 2021-07-07, Lee Shawn C wrote: > > > > >On Tue, 2021-07-07, Almahallawy, Khaled wrote: > > > > >>I believe Imre's LT fallback: > > > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: > > > > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487 > > > > >>should address Chrome concerns for LT failure and LTTPRs > > > > >> > > > > > > > > > >Thanks for comment! The new fallback patch should help on this DPRX problem. > > > > >One more thing. If driver did not handle DPRX link train failed properly. > > > > >It would impact link layer compliance test case in below. > > > > > > > > > >400.3.1.3 > > > > >400.3.1.4 > > > > >400.3.1.6 > > > > >400.3.1.12 > > > > >400.3.1.13 > > > > >400.3.1.14 > > > > > > > > > >Best regards, > > > > >Shawn > > > > > > > > > > > > > Hi all, before Imre's patch series land on upstream driver. The link train failed > > > > handling works for LTTPR only. But DPRX does not. Could you please consider to have > > > > this change as temporary solution? Thanks! > > > > > > I sent already fixing this, see > > > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak@intel.com/ > > > > > > but it fell through the cracks. Applied now your patch, thanks. > > > > We seem to have a tgl that fails consistently at DPRX link training: > > https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html > > > > Previously the error went unnoticed. > > Yea, didn't notice this. Can't see anything obvious, besides that it's a > DPCD rev 1.1 monitor, so maybe not compatible with LTTPRs. I follow up > if I find something. I opened this thread exactly to tell that I'm avoiding this patch on this week's pull request targeting 5.14 exactly because I saw something strange with CI_DIF_604 on TGL that doesn't happen without this patch CI_DIF_603. Since I don't know what's going on there I'm also avoiding d7f213c131ad ("drm/i915/dp: Use max params for panels < eDP 1.4") just in case... > > > > > -- > > Ville Syrjälä > > Intel