From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95A5AC433EF for ; Wed, 8 Sep 2021 16:46:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A6E2610FF for ; Wed, 8 Sep 2021 16:46:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5A6E2610FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CAB4489496; Wed, 8 Sep 2021 16:46:34 +0000 (UTC) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8AC9989458 for ; Wed, 8 Sep 2021 16:46:33 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id c8-20020a7bc008000000b002e6e462e95fso2127419wmb.2 for ; Wed, 08 Sep 2021 09:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0FtxDQcrUwzDD3CEJno/YlqKVX8CmQWK6QX+v2195wo=; b=PhvlH9EFJT+xHlpBrh9zZPI0q72wsNF3oh5eGh9/NSg5MqXB71qFVPj45fZG+BDlYd QL1dKzdTybtOQFKwW9t1hPK/cQvEiYdWbzOZnrlcAHa9l8sTCpw6+YlVlaDNpoLE5QJ3 WZIkEw1MSE8OLLhud9llG/MVlwrGEyJ4J1i9U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0FtxDQcrUwzDD3CEJno/YlqKVX8CmQWK6QX+v2195wo=; b=p4KP+QBVmhkND2GgLptx/yeueJuxireqMtwafKQo0ePECTCmMD29GCXNKyv0by87Sn Uxw3dkbAvBVMAiYqvcIL2Uw2S/g3arBtbzODL15gKFrCV4naWWdcwscTjMR92doOSBK2 8q4tVE/6FNsq8iEMKHiTkXFFtYxc5zGQBg5TIAKXyOpCLXUpfLg6u+AaBdrJuYGLVubF dcZ/A38SsBT6wG2ynNfsuixMN0Jb1ODAWCUNQt8OjS+Fi+2CSvxtZmgeasYa61lbo/tI T24NCTJWmTm3StClmJNYYkB+Iuzs0MPswca4xJMFdKDO7gC7ucWozgkYpPUG9AVB3S4h mkoA== X-Gm-Message-State: AOAM530Tqd3aU1l7OBnpKdd+NfQQdJB/aCIybArQp8c6C3yntuYR1Y9D vd2l0qe+u2FMb+OTdkkS2sw+0A== X-Google-Smtp-Source: ABdhPJx8WESdySp5mpSM7TZvHePNXC8vJnnCRMdVk+GFIUIwjw0LMA0CN7xwDhs35kwEaya8O5ikDA== X-Received: by 2002:a05:600c:1d29:: with SMTP id l41mr4555656wms.177.1631119592080; Wed, 08 Sep 2021 09:46:32 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id m3sm3407321wrg.45.2021.09.08.09.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 09:46:31 -0700 (PDT) Date: Wed, 8 Sep 2021 18:46:29 +0200 From: Daniel Vetter To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Tvrtko Ursulin , Vinay Belgaumkar , Daniele Ceraolo Spurio , Aravind Iddamsetty Message-ID: References: <20210907171916.2548047-1-matthew.d.roper@intel.com> <20210907171916.2548047-3-matthew.d.roper@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210907171916.2548047-3-matthew.d.roper@intel.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 Subject: Re: [Intel-gfx] [PATCH 2/8] drm/i915/xehp: CCS shares the render reset domain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Sep 07, 2021 at 10:19:10AM -0700, Matt Roper wrote: > The reset domain is shared between render and all compute engines, > so resetting one will affect the others. > > Note: Before performing a reset on an RCS or CCS engine, the GuC will > attempt to preempt-to-idle the other non-hung RCS/CCS engines to avoid > impacting other clients (since some shared modules will be reset). If > other engines are executing non-preemptable workloads, the impact is > unavoidable and some work may be lost. > > Bspec: 52549 > Original-patch-by: Michel Thierry > Cc: Tvrtko Ursulin > Cc: Vinay Belgaumkar > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Aravind Iddamsetty > Signed-off-by: Matt Roper Do we have igts validating this all properly? Specifically that the reset stats are incremented correctly for guilty respectively victimized contexts. This is necessary if it doesn't exist yet. Also you need a patch set here that fixes up the igts which have wrong assumptions about context isolation. -Daniel > --- > drivers/gpu/drm/i915/gt/intel_reset.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c > index 91200c43951f..30598c1d070c 100644 > --- a/drivers/gpu/drm/i915/gt/intel_reset.c > +++ b/drivers/gpu/drm/i915/gt/intel_reset.c > @@ -507,6 +507,10 @@ static int gen11_reset_engines(struct intel_gt *gt, > [VECS1] = GEN11_GRDOM_VECS2, > [VECS2] = GEN11_GRDOM_VECS3, > [VECS3] = GEN11_GRDOM_VECS4, > + [CCS0] = GEN11_GRDOM_RENDER, > + [CCS1] = GEN11_GRDOM_RENDER, > + [CCS2] = GEN11_GRDOM_RENDER, > + [CCS3] = GEN11_GRDOM_RENDER, > }; > struct intel_engine_cs *engine; > intel_engine_mask_t tmp; > -- > 2.25.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch