Re: [Intel-gfx] [PATCH v2 3/9] vfio/ccw: Convert to use vfio_register_group_dev()

Jason Gunthorpe
2021-09-27T12:17:34Z

On Fri, Sep 24, 2021 at 04:37:43PM -0400, Eric Farman wrote:
> > @@ -528,6 +534,7 @@ static int __init vfio_ccw_sch_init(void)
> >
> > static void __exit vfio_ccw_sch_exit(void)
> > {
> > + mdev_unregister_driver(&vfio_ccw_mdev_driver);
>
> Wouldn't it be better to mirror the unwind-init case, such that the
> above goes...
>
> > css_driver_unregister(&vfio_ccw_sch_driver);
> > isc_unregister(VFIO_CCW_ISC);
>
> ...here?

Yes, I switched it

Thanks,
Jason