From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B9AC433F5 for ; Wed, 15 Sep 2021 14:05:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35B0461164 for ; Wed, 15 Sep 2021 14:05:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 35B0461164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 139C06E940; Wed, 15 Sep 2021 14:05:12 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F1D36E5C3; Tue, 14 Sep 2021 19:53:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3760161108; Tue, 14 Sep 2021 19:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631649218; bh=th9TFOXsR06Xg/2ttcv1rjgy5eK+72XXt8aYRu+bByo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J5M0TLTr0U8YWN17ZphgSgOsr2LkfGc/XojytM3rF1QIuC2MWJk+hTrgoPUij63Tf ZbK1iGOjiaztEHrnL5vad2ePLBAKUcN1kbiRKDdllueg705sx3t9CQPF/dksuWcCpF zlj9V/fW3WAvq5nZxn6+YWn1IPxkJ4ru23CZmt8YAU/PZ03YdtlWMiMmoghpuNkSeh S4NZsiBS+u+8Wx1VRDVaVJMazZM2ZRgiyu6L77M8++T3suP5qVHK3rnjA5DQCkChLN 18yNPa2S3CWiv3K22BWh1xIG6nTmWleS/yUu/XLKdD/bCeditfV4GkDlflsqU1n3KB /VfLJbmib9UcA== Date: Tue, 14 Sep 2021 12:53:31 -0700 From: Nathan Chancellor To: Jani Nikula Cc: Joonas Lahtinen , Rodrigo Vivi , Jason Ekstrand , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Matthew Auld , "Michael J. Ruhl" , Nick Desaulniers , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, llvm@lists.linux.dev Message-ID: References: <20210824225427.2065517-1-nathan@kernel.org> <87wnnj13t5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wnnj13t5.fsf@intel.com> X-Mailman-Approved-At: Wed, 15 Sep 2021 14:05:10 +0000 Subject: Re: [Intel-gfx] [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Sep 14, 2021 at 08:10:14PM +0300, Jani Nikula wrote: > On Mon, 13 Sep 2021, Nathan Chancellor wrote: > > On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: > >> Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") > >> disabled -Wsometimes-uninitialized as noisy but there have been a few > >> fixes to clang that make the false positive rate fairly low so it should > >> be enabled to help catch obvious mistakes. The first two patches fix > >> revent instances of this warning then enables it for i915 like the rest > >> of the tree. > >> > >> Cheers, > >> Nathan > >> > >> Nathan Chancellor (3): > >> drm/i915/selftests: Do not use import_obj uninitialized > >> drm/i915/selftests: Always initialize err in > >> igt_dmabuf_import_same_driver_lmem() > >> drm/i915: Enable -Wsometimes-uninitialized > >> > >> drivers/gpu/drm/i915/Makefile | 1 - > >> drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 7 ++++--- > >> 2 files changed, 4 insertions(+), 4 deletions(-) > >> > >> > >> base-commit: fb43ebc83e069625cfeeb2490efc3ffa0013bfa4 > >> -- > >> 2.33.0 > >> > >> > > > > Ping, could this be picked up for an -rc as these are very clearly bugs? > > Thanks for the patches and review. Pushed to drm-intel-gt-next and > cherry-picked to drm-intel-fixes, header to -rc2. Thanks a lot! Cheers, Nathan