From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0524C433EF for ; Mon, 18 Oct 2021 13:23:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A3FD6103D for ; Mon, 18 Oct 2021 13:23:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7A3FD6103D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 190916E09A; Mon, 18 Oct 2021 13:23:18 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37F1F6E09A for ; Mon, 18 Oct 2021 13:23:17 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10140"; a="208349275" X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="208349275" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 06:23:16 -0700 X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="482730679" Received: from mhe-mobl1.amr.corp.intel.com (HELO intel.com) ([10.212.124.254]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 06:23:15 -0700 Date: Mon, 18 Oct 2021 09:23:13 -0400 From: Rodrigo Vivi To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Joonas Lahtinen Message-ID: References: <20211015091650.87270-1-rodrigo.vivi@intel.com> <87mtn6u4df.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mtn6u4df.fsf@intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Don't propagate the gen split confusion further X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Oct 18, 2021 at 11:25:00AM +0300, Jani Nikula wrote: > On Fri, 15 Oct 2021, Rodrigo Vivi wrote: > > There's no such thing as gen13. It is either display 13 > > or graphics 13. Don't propagate the gen12 confusion > > further. > > Reviewed-by: Jani Nikula thanks, pushed > > > > > Cc: Joonas Lahtinen > > Cc: Jani Nikula > > Signed-off-by: Rodrigo Vivi > > --- > > drivers/gpu/drm/i915/i915_reg.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > > index da9055c3ebf0..1e221fbe37fd 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -8263,7 +8263,7 @@ enum { > > > > /* > > * The below are numbered starting from "S1" on gen11/gen12, but starting > > - * with gen13 display, the bspec switches to a 0-based numbering scheme > > + * with display 13, the bspec switches to a 0-based numbering scheme > > * (although the addresses stay the same so new S0 = old S1, new S1 = old S2). > > * We'll just use the 0-based numbering here for all platforms since it's the > > * way things will be named by the hardware team going forward, plus it's more > > -- > Jani Nikula, Intel Open Source Graphics Center