From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F919C433F5 for ; Tue, 19 Oct 2021 07:17:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EE0F60F8F for ; Tue, 19 Oct 2021 07:17:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9EE0F60F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31FE06E12B; Tue, 19 Oct 2021 07:17:11 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A161D6E12B for ; Tue, 19 Oct 2021 07:17:09 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="289290156" X-IronPort-AV: E=Sophos;i="5.85,383,1624345200"; d="scan'208";a="289290156" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 00:17:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,383,1624345200"; d="scan'208";a="490183535" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga007.fm.intel.com with SMTP; 19 Oct 2021 00:17:05 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 19 Oct 2021 10:17:04 +0300 Date: Tue, 19 Oct 2021 10:17:04 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: David Airlie Cc: "Development, Intel" , Jani Nikula Message-ID: References: <20211015071625.593-5-ville.syrjala@linux.intel.com> <20211018153525.21597-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH v2 4/9] drm/i915: Move LPT PCH readout code X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Oct 19, 2021 at 05:46:33AM +1000, David Airlie wrote: > On Tue, Oct 19, 2021 at 1:35 AM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > Nuke the hsw_get_ddi_port_state() eyesore by putting the > > readout code into intel_pch_display.c, and calling it directly > > from hsw_crt_get_config(). > > > > Note that the nuked TRANS_DDI_FUNC_CTL readout from > > hsw_get_ddi_port_state() is now etirely redundant since we > > get called from the encoder->get_config() so we already know > > we're dealing with the correct DDI port. Previously the > > code was called from a place where that wasn't known so > > it had to checked manually. > > > > v2: Clarify the TRANS_DDI_FUNC_CTL change (Dave) > > Nuke the now unused *TRANS_DDI_FUNC_CTL_VAL_TO_PORT() (Dave) > > > > Cc: Dave Airlie > > Cc: Jani Nikula > > Signed-off-by: Ville Syrjälä > > Reviewed-by: Dave Airlie Thanks for the review. Fixed up all the (known) typos and robot noises, and pushed to drm-intel-next. -- Ville Syrjälä Intel