Re: [Intel-gfx] [PATCH v2 07/13] drm/msm: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

Dmitry Baryshkov
2021-11-29T13:00:36Z

On 16/10/2021 21:42, Claudio Suarez wrote:
> Once EDID is parsed, the monitor HDMI support information is available
> through drm_display_info.is_hdmi. Retriving the same information with
> drm_detect_hdmi_monitor() is less efficient. Change to
> drm_display_info.is_hdmi
>
> Signed-off-by: Claudio Suarez <cssk@net-c.es>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
> drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> index 58707a1f3878..07585092f919 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> @@ -364,8 +364,8 @@ static int msm_hdmi_connector_get_modes(struct drm_connector *connector)
>
> hdmi_write(hdmi, REG_HDMI_CTRL, hdmi_ctrl);
>
> - hdmi->hdmi_mode = drm_detect_hdmi_monitor(edid);
> drm_connector_update_edid_property(connector, edid);
> + hdmi->hdmi_mode = connector->display_info.is_hdmi;
>
> if (edid) {
> ret = drm_add_edid_modes(connector, edid);
>

--
With best wishes
Dmitry