From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB27EC433EF for ; Fri, 8 Oct 2021 23:03:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 881B760FE8 for ; Fri, 8 Oct 2021 23:03:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 881B760FE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 350B76E072; Fri, 8 Oct 2021 23:03:38 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C6DC6E072 for ; Fri, 8 Oct 2021 23:03:36 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10131"; a="290103292" X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="290103292" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2021 16:03:36 -0700 X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="489648004" Received: from ypeng18-mobl.ger.corp.intel.com (HELO intel.com) ([10.249.40.52]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2021 16:03:34 -0700 Date: Sat, 9 Oct 2021 01:03:31 +0200 From: Andi Shyti To: Sujaritha Sundaresan Cc: intel-gfx@lists.freedesktop.org, Dale B Stimson Message-ID: References: <20211008204454.11680-1-sujaritha.sundaresan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211008204454.11680-1-sujaritha.sundaresan@intel.com> Subject: Re: [Intel-gfx] [PATCH 1/1] RFC : drm/i915: Adding new sysfs frequency attributes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Sujaritha, On Fri, Oct 08, 2021 at 01:44:54PM -0700, Sujaritha Sundaresan wrote: > This patch adds the following new sysfs frequency attributes; > - punit_req_freq_mhz > - throttle_reason_status > - throttle_reason_pl1 > - throttle_reason_pl2 > - throttle_reason_pl4 > - throttle_reason_thermal > - throttle_reason_prochot > - throttle_reason_ratl > - throttle_reason_vr_thermalert > - throttle_reason_vr_tdc > > Signed-off-by: Sujaritha Sundaresan > Cc: Dale B Stimson > --- > drivers/gpu/drm/i915/gt/intel_rps.c | 83 +++++++++++++++++ > drivers/gpu/drm/i915/gt/intel_rps.h | 10 +++ > drivers/gpu/drm/i915/i915_reg.h | 11 +++ > drivers/gpu/drm/i915/i915_sysfs.c | 135 ++++++++++++++++++++++++++++ if we add these here we're stuck forever! Can this hold a few days? The rest of the patch looks OK to me. Andi