From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E92C433FE for ; Wed, 13 Oct 2021 14:14:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D191E610A2 for ; Wed, 13 Oct 2021 14:14:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D191E610A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 25A966EA04; Wed, 13 Oct 2021 14:14:50 +0000 (UTC) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE5BB6EA04 for ; Wed, 13 Oct 2021 14:14:48 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id i12so8888703wrb.7 for ; Wed, 13 Oct 2021 07:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=QGMl28YhRUiVkwlLZBmVBXM/gyOekGqQg/96lael90E=; b=P0JFBTHJb1PbNMI8zjyzr7d9fJsFYOFHA0yBi6E2RZWs9BbG3pgP09Q5ZbfNPBYrfe omcKg0S8cPzW2K3NVO1TtfBvQGSQmGi81ZTXvdFcqcuT3/GvLOrN8on5acW1QONc+L3Q dVWlOopJ2jZgRk57IgcSw6BClvk7y94ehK1mY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=QGMl28YhRUiVkwlLZBmVBXM/gyOekGqQg/96lael90E=; b=2xdzGh3RVLb32RnefrwZoRygGgwfq+mJ5L2aoJKpAlvIoT9q2Go7mi8At5JSSWCVw8 Y6h5tJP3sO6FOA8FE3HRrAmqQn49A87l9as+KHqpYen0s4L2fG25sDp7MUCTmftg/wMH ywKgnL1q+RqLNwMLV2Y7Sd+1eCqB4DlWNAWfuEyzVp/mBAzzFyOyHEzbSfgKyhwqAE/m 194at7OtPq/tL2whXIJANp7EM0EP/qXff3OP3K9IRkUM9lTpBmNln3nVn6XmtqPeJ/PO 4lK9UIF75pMvQP3uA8rF8O2wmWlOTpeLQOHZZ+rL3j28mnqX/57pKsWGdhzhPxs3nFlf WUdA== X-Gm-Message-State: AOAM530mCjv/K9QUVIwnBY/9qauZrJ6XB2HsC0KXFdV40AH7XUbRHqNT xIOEmkTOGTN9zY00+q9Hx9BMWmm2Bar42Q== X-Google-Smtp-Source: ABdhPJz3DWZJUUUVjvwZK5GxUdwNkVvvYKU7kkJTlhYb5/u8jsP/6ywjOD2vzguomUiuBwi9+TI1iA== X-Received: by 2002:a5d:6ad2:: with SMTP id u18mr40933209wrw.47.1634134487220; Wed, 13 Oct 2021 07:14:47 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id b190sm5490616wmd.25.2021.10.13.07.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 07:14:46 -0700 (PDT) Date: Wed, 13 Oct 2021 16:14:44 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, daniel@ffwll.ch, tvrtko.ursulin@linux.intel.com Message-ID: References: <20211005113742.1101-1-christian.koenig@amd.com> <20211005113742.1101-15-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211005113742.1101-15-christian.koenig@amd.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 Subject: Re: [Intel-gfx] [PATCH 14/28] drm/msm: use new iterator in msm_gem_describe X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Oct 05, 2021 at 01:37:28PM +0200, Christian König wrote: > Simplifying the code a bit. Also drop the RCU read side lock since the > object is locked anyway. > > Untested since I can't get the driver to compile on !ARM. Cross-compiler install is pretty easy and you should have that for pushing drm changes to drm-misc :-) > Signed-off-by: Christian König Assuming this compiles, it looks correct. Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/msm/msm_gem.c | 19 +++++-------------- > 1 file changed, 5 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c > index 40a9863f5951..5bd511f07c07 100644 > --- a/drivers/gpu/drm/msm/msm_gem.c > +++ b/drivers/gpu/drm/msm/msm_gem.c > @@ -880,7 +880,7 @@ void msm_gem_describe(struct drm_gem_object *obj, struct seq_file *m, > { > struct msm_gem_object *msm_obj = to_msm_bo(obj); > struct dma_resv *robj = obj->resv; > - struct dma_resv_list *fobj; > + struct dma_resv_iter cursor; > struct dma_fence *fence; > struct msm_gem_vma *vma; > uint64_t off = drm_vma_node_start(&obj->vma_node); > @@ -955,22 +955,13 @@ void msm_gem_describe(struct drm_gem_object *obj, struct seq_file *m, > seq_puts(m, "\n"); > } > > - rcu_read_lock(); > - fobj = dma_resv_shared_list(robj); > - if (fobj) { > - unsigned int i, shared_count = fobj->shared_count; > - > - for (i = 0; i < shared_count; i++) { > - fence = rcu_dereference(fobj->shared[i]); > + dma_resv_for_each_fence(&cursor, robj, true, fence) { > + if (dma_resv_iter_is_exclusive(&cursor)) > + describe_fence(fence, "Exclusive", m); > + else > describe_fence(fence, "Shared", m); > - } > } > > - fence = dma_resv_excl_fence(robj); > - if (fence) > - describe_fence(fence, "Exclusive", m); > - rcu_read_unlock(); > - > msm_gem_unlock(obj); > } > > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch