From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4340C433F5 for ; Wed, 13 Oct 2021 22:38:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A23F261130 for ; Wed, 13 Oct 2021 22:38:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A23F261130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D5BD6E878; Wed, 13 Oct 2021 22:38:19 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id C86716E878 for ; Wed, 13 Oct 2021 22:38:17 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="208354515" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="208354515" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 15:38:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="441836714" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga006.jf.intel.com with SMTP; 13 Oct 2021 15:38:15 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 14 Oct 2021 01:38:14 +0300 Date: Thu, 14 Oct 2021 01:38:14 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Imre Deak Cc: intel-gfx@lists.freedesktop.org Message-ID: References: <20211007203517.3364336-1-imre.deak@intel.com> <20211007203517.3364336-10-imre.deak@intel.com> <20211013213255.GD19061@ideak-desk.fi.intel.com> <20211013222824.GE19061@ideak-desk.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211013222824.GE19061@ideak-desk.fi.intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 09/11] drm/i915: Add a platform independent way to check for CCS control planes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Oct 14, 2021 at 01:28:24AM +0300, Imre Deak wrote: > On Thu, Oct 14, 2021 at 12:54:58AM +0300, Ville Syrjälä wrote: > > On Thu, Oct 14, 2021 at 12:32:55AM +0300, Imre Deak wrote: > > > On Wed, Oct 13, 2021 at 11:45:33PM +0300, Ville Syrjälä wrote: > > > > On Wed, Oct 13, 2021 at 11:27:02PM +0300, Ville Syrjälä wrote: > > > > > On Thu, Oct 07, 2021 at 11:35:15PM +0300, Imre Deak wrote: > > > > > > Future platforms change the location of CCS control planes in CCS > > > > > > framebuffers, so add intel_fb_is_rc_ccs_ctrl_plane() to query for these > > > > > > > > > > Don't we use the term 'ccs_plane' everywhere else? > > > > > > > > > > > planes independently of the platform. This function can be used > > > > > > everywhere instead of is_ccs_plane() (or is_ccs_plane() && !cc_plane()), > > > > > > since all the callers are only interested in control planes (and not CCS > > > > > > color-clear planes). > > > > > > > > Hmm. I guess you're changing the terminology across the board? > > > > If it's used consistently then no objections from me. > > > > > > ccs_plane has been used as a generic term for both the "control" and the > > > cc plane, or at least I thought of it as such. > > > > The official definition I think is: > > CCS == color control surface > > > > So in terms of modifier naming I suppose I tend to think > > of it like this: > > modifier name has CCS -> color control surface is present > > modifier name has CC -> clear color is present > > > > But if we want to make the distinction somehow stronger I was > > thinking maybe ccs_aux vs. ccs_cc. But dunno if that just ends up > > being more confusing since AUX_DIST is also used for planar scanout > > on skl/etc. I guess the fact that it would also say "ccs" in additon to "aux" would make it ok. So ccs_aux goes into AUX_DIST, ccs_cc goes into CC_VAL. But anyway, as long we go with something consitent everywhere I'll be happy. -- Ville Syrjälä Intel