From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94CB0C433EF for ; Sun, 17 Oct 2021 20:48:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53D6760F23 for ; Sun, 17 Oct 2021 20:48:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 53D6760F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CF896E581; Sun, 17 Oct 2021 20:48:18 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51D736E570; Sun, 17 Oct 2021 20:48:16 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10140"; a="251591811" X-IronPort-AV: E=Sophos;i="5.85,380,1624345200"; d="scan'208";a="251591811" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2021 13:48:15 -0700 X-IronPort-AV: E=Sophos;i="5.85,380,1624345200"; d="scan'208";a="493329324" Received: from nidhinms-mobl.gar.corp.intel.com (HELO intel.com) ([10.249.44.7]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2021 13:48:11 -0700 Date: Sun, 17 Oct 2021 22:48:07 +0200 From: Andi Shyti To: "Sundaresan, Sujaritha" Cc: Andi Shyti , Intel GFX , DRI Devel , Tvrtko Ursulin , Chris Wilson , Lucas De Marchi , Matt Roper , Andi Shyti Message-ID: References: <20211014000817.39227-1-andi@etezian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: make a gt sysfs group and move power management files X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Sujaritha, [...] > > +void intel_gt_sysfs_unregister(struct intel_gt *gt) > > +{ > > +} > > Is there a reason for this function to not be populated ? yes, there is, indeed, something missing here. There has been a fix bout this floating around from Chris about sysfs_gt kobjects. I will check if we can add the fix at the next verion. Thanks, Andi