Re: [Intel-gfx] [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

Harry Wentland
2021-10-26T15:40:33Z

On 2021-10-12 16:58, Shankar, Uma wrote:
>
>
>> -----Original Message-----
>> From: Pekka Paalanen <ppaalanen@gmail.com>
>> Sent: Tuesday, October 12, 2021 4:01 PM
>> To: Shankar, Uma <uma.shankar@intel.com>
>> Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
>> harry.wentland@amd.com; ville.syrjala@linux.intel.com;
>> brian.starkey@arm.com; sebastian@sebastianwick.net;
>> Shashank.Sharma@amd.com
>> Subject: Re: [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline
>>
>> On Tue, 7 Sep 2021 03:08:43 +0530
>> Uma Shankar <uma.shankar@intel.com> wrote:
>>

snip

>>> +
>>> +
>>> +This patch series adds properties for plane color features. It adds
>>> +properties for degamma used to linearize data and CSC used for
>>> +gamut conversion. It also includes Gamma support used to again
>>> +non-linearize data as per panel supported color space. These can be
>>> +utilize by user space to convert planes from one format to another,
>>> +one color space to another etc.
>>
>> FWIW, this is exactly the structure I have assumed in the Weston CM&HDR work.
>
> This is great to hear that we are aligned wrt how the pipeline should work.
>
> Thanks Pekka for taking time out and providing the feedback.
>
> @harry.wentland@amd.com We can work together and build our design to accommodate
> both Intel and AMD's hardware needs. This will also make things generic enough for any
> other hardware vendor as well.
>

Definitely. I think we're on the right path. Personally I would like to
arrive at a solid KMS definition for this by the time Weston guys
get to the HDR enablement with SW composition so we can start looking
at KMS offloading for HDR planes as next step.

Harry

> Thanks & Regards,
> Uma Shankar
>
>>> +
>>> +Userspace can take smart blending decisions and utilize these
>>> +hardware supported plane color features to get accurate color
>>> +profile. The same can help in consistent color quality from source
>>> +to panel taking advantage of advanced color features in hardware.
>>> +
>>> +These patches add the property interfaces and enable helper functions.
>>> +This series adds Intel's XE_LPD hw specific plane gamma feature. We
>>> +can build up and add other platform/hardware specific
>>> +implementation on top of this series.
>>> +
>>> +Credits: Special mention and credits to Ville Syrjala for coming up
>>> +with a design for this feature and inputs. This series is based on
>>> +his original design and idea.
>>
>>
>> Thanks,
>> pq