From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E1DBC433EF for ; Wed, 17 Nov 2021 18:54:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AB2B61212 for ; Wed, 17 Nov 2021 18:54:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5AB2B61212 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C61666E829; Wed, 17 Nov 2021 18:54:30 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8004B6E7E2; Wed, 17 Nov 2021 18:54:29 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10171"; a="234267575" X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="234267575" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2021 10:54:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="586755727" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by FMSMGA003.fm.intel.com with SMTP; 17 Nov 2021 10:54:26 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 17 Nov 2021 20:54:26 +0200 Date: Wed, 17 Nov 2021 20:54:26 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Matt Roper Message-ID: References: <20211116174818.2128062-1-matthew.d.roper@intel.com> <20211116174818.2128062-6-matthew.d.roper@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Nov 17, 2021 at 08:43:19PM +0200, Ville Syrjälä wrote: > On Tue, Nov 16, 2021 at 09:48:18AM -0800, Matt Roper wrote: > > From: Matt Atwood > > > > Extend existing workaround 1409120013 to DG2. > > I don't see this listed for DG2. > > > > > Cc: José Roberto de Souza > > Signed-off-by: Matt Atwood > > Signed-off-by: Matt Roper > > --- > > drivers/gpu/drm/i915/intel_pm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > index 89dc7f69baf3..e721c421cc58 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -7444,9 +7444,9 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv) > > > > static void gen12lp_init_clock_gating(struct drm_i915_private *dev_priv) > > { > > - /* Wa_1409120013:tgl,rkl,adl-s,dg1 */ > > + /* Wa_1409120013:tgl,rkl,adl-s,dg1,dg2 */ > > if (IS_TIGERLAKE(dev_priv) || IS_ROCKETLAKE(dev_priv) || > > - IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv)) > > + IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv) || IS_DG2(dev_priv)) AFAIK we're not even calling this function on dg2, so this is just dead code. And in fact without dg2 this seems to be the same as DISPLAY_VER==12 so we shuld stop calling it on adl-p as well. We could then rip out most of the platform checks in here. > > intel_uncore_write(&dev_priv->uncore, ILK_DPFC_CHICKEN, > > DPFC_CHICKEN_COMP_DUMMY_PIXEL); > > > > -- > > 2.33.0 > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel