From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECF7FC433F5 for ; Mon, 22 Nov 2021 14:08:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C11F89C93; Mon, 22 Nov 2021 14:08:18 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DD2A89C93; Mon, 22 Nov 2021 14:08:17 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10175"; a="232274872" X-IronPort-AV: E=Sophos;i="5.87,255,1631602800"; d="scan'208";a="232274872" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 06:08:16 -0800 X-IronPort-AV: E=Sophos;i="5.87,255,1631602800"; d="scan'208";a="508960225" Received: from calebjia-mobl.gar.corp.intel.com (HELO intel.com) ([10.255.37.192]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 06:08:14 -0800 Date: Mon, 22 Nov 2021 09:08:12 -0500 From: Rodrigo Vivi To: Anshuman Gupta Message-ID: References: <20211116155238.3226516-1-tilak.tangudu@intel.com> <20211122134816.GA30494@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211122134816.GA30494@intel.com> Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/rpm: Enable runtime pm autosuspend by default X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ville.syrjala@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Nov 22, 2021 at 07:18:17PM +0530, Anshuman Gupta wrote: > On 2021-11-16 at 21:22:38 +0530, Tilak Tangudu wrote: > > v1: Enable runtime pm autosuspend by default for Gen12 > > and later versions. > > > > v2: Enable runtime pm autosuspend by default for all > > platforms(Syrjala Ville) > > > > v3: Change commit message(Nikula Jani) > It would require to reorder the commit log, version log > need to move after commit message. Well noticed. I changed while pushing. So, for the record: Reviewed-by: Rodrigo Vivi Signed-off-by: Rodrigo Vivi > Thanks, > Anshuman. > > Let's enable runtime pm autosuspend by default everywhere. > > So, we can allow D3hot and bigger power savings on idle scenarios. > > > > But at this time let's not touch the autosuspend_delay time, > > what caused some regression on our previous attempt. > > > > Also, the latest identified issue on GuC PM has been fixed by > > commit 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering > > context") > > > > Signed-off-by: Tilak Tangudu > > --- > > drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c > > index 0d85f3c5c526..22dab36afcb6 100644 > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > > @@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) > > pm_runtime_use_autosuspend(kdev); > > } > > > > + /* Enable by default */ > > + pm_runtime_allow(kdev); > > + > > /* > > * The core calls the driver load handler with an RPM reference held. > > * We drop that here and will reacquire it during unloading in > > -- > > 2.25.1 > >