From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94D46C433F5 for ; Tue, 30 Nov 2021 10:01:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5BC76EC77; Tue, 30 Nov 2021 10:01:49 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF6D96EBB5 for ; Tue, 30 Nov 2021 10:01:47 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10183"; a="260139658" X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208";a="260139658" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 02:01:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208";a="654067538" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga001.fm.intel.com with SMTP; 30 Nov 2021 02:01:42 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 30 Nov 2021 12:01:41 +0200 Date: Tue, 30 Nov 2021 12:01:41 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: <20211125202750.3263848-1-uma.shankar@intel.com> <20211125202750.3263848-3-uma.shankar@intel.com> <87ee6zj5nb.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ee6zj5nb.fsf@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Nov 29, 2021 at 06:19:52PM +0200, Jani Nikula wrote: > On Fri, 26 Nov 2021, Uma Shankar wrote: > > Enable Pipe Degamma for XE_LPD. Extend the legacy implementation > > to incorparate the extended lut size for XE_LPD. > > > > v2: Added a helper for degamma lut size (Ville) > > > > Signed-off-by: Uma Shankar > > --- > > drivers/gpu/drm/i915/display/intel_color.c | 14 +++++++++++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c > > index 42fe549ef6fe..de3ded1e327a 100644 > > --- a/drivers/gpu/drm/i915/display/intel_color.c > > +++ b/drivers/gpu/drm/i915/display/intel_color.c > > @@ -808,6 +808,14 @@ static void bdw_load_luts(const struct intel_crtc_state *crtc_state) > > } > > } > > > > +static int glk_degamma_lut_size(struct drm_i915_private *i915) > > +{ > > + if (DISPLAY_VER(i915) >= 13) > > + return 131; > > + else > > + return 35; > > +} > > + > > Why do we have both a function with hardcoded values and device info > members for this? The device info stuff just needs to get nuked. The size of the LUTs depends on the gamma mode which we already select dynamically (and if/when we get thre new uapi ironed out it'll become even more dynamic), so trying to represent it with a single number in device info is futile. -- Ville Syrjälä Intel