From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 283F2C433F5 for ; Thu, 2 Dec 2021 11:13:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7157B6EEAB; Thu, 2 Dec 2021 11:13:33 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 600416EEA8 for ; Thu, 2 Dec 2021 11:13:32 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="300076270" X-IronPort-AV: E=Sophos;i="5.87,281,1631602800"; d="scan'208";a="300076270" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2021 03:13:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,281,1631602800"; d="scan'208";a="655354072" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga001.fm.intel.com with SMTP; 02 Dec 2021 03:13:28 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 02 Dec 2021 13:13:28 +0200 Date: Thu, 2 Dec 2021 13:13:28 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Srinivas, Vidya" Message-ID: References: <20211130171220.8622-1-vidya.srinivas@intel.com> <20211201034727.1666-1-vidya.srinivas@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yashashvi, Shantam" , "intel-gfx@lists.freedesktop.org" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Dec 02, 2021 at 11:10:37AM +0000, Srinivas, Vidya wrote: > > > > -----Original Message----- > > From: Ville Syrjälä > > Sent: Thursday, December 2, 2021 4:26 PM > > To: Srinivas, Vidya > > Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam > > > > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width > > > > On Thu, Dec 02, 2021 at 03:25:34AM +0000, Srinivas, Vidya wrote: > > > > > > > > > > -----Original Message----- > > > > From: Ville Syrjälä > > > > Sent: Wednesday, December 1, 2021 8:33 PM > > > > To: Srinivas, Vidya > > > > Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam > > > > > > > > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in > > > > max_width > > > > > > > > On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote: > > > > > PLANE_CUS_CTL has a restriction of 4096 width even though > > > > > PLANE_SIZE and scaler size registers supports max 5120. > > > > > Take care of this restriction in max_width. > > > > > > > > > > Without this patch, when 5k content is sent on HDR plane with NV12 > > > > > content, FIFO underrun is seen and screen blanks out. > > > > > > > > > > v2: Addressed review comments from Ville. Added separate functions > > > > > for max_width - for HDR and SDR > > > > > > > > > > v3: Addressed review comments from Ville. Changed names of HDR and > > > > SDR > > > > > max_width functions to icl_hdr_plane_max_width and > > > > > icl_sdr_plane_max_width > > > > > > > > > > v4: Fixed paranthesis alignment. No code change > > > > > > > > > > Reviewed-by: Ville Syrjälä > > > > > Signed-off-by: Vidya Srinivas > > > > > Signed-off-by: Yashashvi Shantam > > > > > > > > Hmm. What's this extra sob doing here? > > > > > > Hello Ville, sincere apologies. When I run checkpatch.pl I see no warnings > > on my host. > > > However patchwork keeps reporting paranthesis alignment warning. > > > I tried to push it multiple times after running checkpatch.pl on my host. > > Really sorry about that. > > > > I was asking about the extra "signed-off-by" (sob). > > Hello Ville, I am really sorry about that. Should I keep single signed-off-by and push the patch > again? Kindly let me know. Thank you. Yeah, please resend with proper signed-off-by. -- Ville Syrjälä Intel