From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B616C433F5 for ; Wed, 8 Dec 2021 16:08:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91E216FDEE; Wed, 8 Dec 2021 16:08:16 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 338B66FD08; Wed, 8 Dec 2021 16:08:15 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10192"; a="298652769" X-IronPort-AV: E=Sophos;i="5.88,189,1635231600"; d="scan'208";a="298652769" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 08:08:07 -0800 X-IronPort-AV: E=Sophos;i="5.88,189,1635231600"; d="scan'208";a="515811776" Received: from faerberc-mobl2.ger.corp.intel.com (HELO intel.com) ([10.251.209.148]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 08:08:04 -0800 Date: Wed, 8 Dec 2021 18:08:00 +0200 From: Andi Shyti To: Ramalingam C Message-ID: References: <20211208141613.7251-1-ramalingam.c@intel.com> <20211208141613.7251-2-ramalingam.c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208141613.7251-2-ramalingam.c@intel.com> Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , Hellstrom Thomas , Lucas De Marchi , dri-devel Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Ram, Reviewed-by: Andi Shyti but just two notes on the patchstyle, no need to resend: 1. would be nice to have [PATCH v2...] otherwise it's difficult to see if I'm reading the correct version. (I don't see the difficulty 'git format-patch -v 2...') > Add a new platform flag, has_64k_pages, to mark the requirement of 64K > GTT page sizes or larger for device local memory access. > > Also implies that we require or at least support the compact PT layout > for the ppGTT when using 64K GTT pages. > > v2: More explanation for the flag [Thomas] > > Signed-off-by: Stuart Summers > Signed-off-by: Ramalingam C > Reviewed-by: Lucas De Marchi 2. the tag part has a temporal meaning: Stuart has written the patch, Lucas has reviewed it and you are sending it, therefore, the correct order should be: Signed-off-by: Stuart Summers Reviewed-by: Lucas De Marchi Signed-off-by: Ramalingam C Thanks, Andi