From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED6F0C4332F for ; Thu, 9 Dec 2021 17:26:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE6E910E1DE; Thu, 9 Dec 2021 17:26:08 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 25FD710E1DB; Thu, 9 Dec 2021 17:26:07 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10193"; a="298950809" X-IronPort-AV: E=Sophos;i="5.88,193,1635231600"; d="scan'208";a="298950809" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2021 09:26:06 -0800 X-IronPort-AV: E=Sophos;i="5.88,193,1635231600"; d="scan'208";a="516397649" Received: from achlenov-mobl2.ccr.corp.intel.com (HELO intel.com) ([10.252.52.59]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2021 09:26:04 -0800 Date: Thu, 9 Dec 2021 19:26:00 +0200 From: Andi Shyti To: Jani Nikula Message-ID: References: <20211209132512.47241-1-andi.shyti@linux.intel.com> <20211209132512.47241-2-andi.shyti@linux.intel.com> <87ilvx3dz9.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ilvx3dz9.fsf@intel.com> Subject: Re: [Intel-gfx] [PATCH v6 01/11] drm/i915: Store backpointer to GT in uncore X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?Q?Micha=C5=82?= Winiarski , Intel GFX , Lucas De Marchi , DRI Devel , Chris Wilson Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Jani, thanks for looking at it. > > - intel_gt_init_early(&dev_priv->gt, dev_priv); > > + __intel_gt_init_early(&dev_priv->gt, dev_priv); > > Why double underscores here? It looks like it's supposed to be internal > to intel_gt, not to be called by anyone else. I forgot to write two lines in the commit log about this. It's a temporary solution that will go away in the next patch series[*]. The reason for it is because at this point I need to break the early initialization of the gt into two parts. In the specific the '__intel_gt_init_early' assigns the i915 private data and the uncore. It's not pretty, but, knowing what's coming next, it's the change with the smallest impact. > > > > i915_gem_init_early(dev_priv); > > Thank you, Andi [*] https://patchwork.freedesktop.org/patch/464475/?series=97352&rev=1