From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8867BC433F5 for ; Thu, 9 Dec 2021 17:46:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D538289C1A; Thu, 9 Dec 2021 17:46:37 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id E108589C1A for ; Thu, 9 Dec 2021 17:46:36 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10193"; a="218189471" X-IronPort-AV: E=Sophos;i="5.88,193,1635231600"; d="scan'208";a="218189471" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2021 09:46:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,193,1635231600"; d="scan'208";a="463335690" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga006.jf.intel.com with SMTP; 09 Dec 2021 09:46:32 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 09 Dec 2021 19:46:32 +0200 Date: Thu, 9 Dec 2021 19:46:32 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/cdclk: hide struct intel_cdclk_vals X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Dec 09, 2021 at 06:51:24PM +0200, Jani Nikula wrote: > The definition is not needed outside of intel_cdclk.c. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 8 ++++++++ > drivers/gpu/drm/i915/display/intel_cdclk.h | 8 -------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c > index 84674a4f7226..56f40d9430b8 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > @@ -1219,6 +1219,14 @@ static bool has_cdclk_squasher(struct drm_i915_private *i915) > return IS_DG2(i915); > } > > +struct intel_cdclk_vals { > + u32 cdclk; > + u16 refclk; > + u16 waveform; > + u8 divider; /* CD2X divider * 2 */ > + u8 ratio; > +}; > + > static const struct intel_cdclk_vals bxt_cdclk_table[] = { > { .refclk = 19200, .cdclk = 144000, .divider = 8, .ratio = 60 }, > { .refclk = 19200, .cdclk = 288000, .divider = 4, .ratio = 60 }, > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.h b/drivers/gpu/drm/i915/display/intel_cdclk.h > index 77e8c8e1708f..50b93226517e 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.h > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.h > @@ -16,14 +16,6 @@ struct drm_i915_private; > struct intel_atomic_state; > struct intel_crtc_state; > > -struct intel_cdclk_vals { > - u32 cdclk; > - u16 refclk; > - u16 waveform; > - u8 divider; /* CD2X divider * 2 */ > - u8 ratio; > -}; > - > struct intel_cdclk_state { > struct intel_global_state base; > > -- > 2.30.2 -- Ville Syrjälä Intel