From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 526E0C433EF for ; Thu, 9 Dec 2021 17:57:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9418610E12D; Thu, 9 Dec 2021 17:57:09 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B74910E12D for ; Thu, 9 Dec 2021 17:57:08 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10193"; a="298957392" X-IronPort-AV: E=Sophos;i="5.88,193,1635231600"; d="scan'208";a="298957392" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2021 09:57:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,193,1635231600"; d="scan'208";a="601644067" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by FMSMGA003.fm.intel.com with SMTP; 09 Dec 2021 09:57:05 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 09 Dec 2021 19:57:05 +0200 Date: Thu, 9 Dec 2021 19:57:05 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 0/4] drm/i915/cdclk: improve abstractions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Dec 09, 2021 at 06:51:21PM +0200, Jani Nikula wrote: > Clean up the cdclk header dependencies. > > Jani Nikula (4): > drm/i915/cdclk: move intel_atomic_check_cdclk() to intel_cdclk.c > drm/i915/cdclk: un-inline intel_cdclk_state functions > drm/i915/cdclk: hide struct intel_cdclk_vals > drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency Another low hanging fruit would be to move struct intel_cdclk_funcs definition into intel_cdclk.c. > > drivers/gpu/drm/i915/display/intel_atomic.c | 1 + > drivers/gpu/drm/i915/display/intel_cdclk.c | 81 +++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_cdclk.h | 26 +++---- > drivers/gpu/drm/i915/display/intel_display.c | 55 +------------ > drivers/gpu/drm/i915/i915_drv.h | 6 +- > 5 files changed, 96 insertions(+), 73 deletions(-) > > -- > 2.30.2 -- Ville Syrjälä Intel