From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 177AEC433F5 for ; Wed, 15 Dec 2021 13:25:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8884210EE16; Wed, 15 Dec 2021 13:25:24 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 363B210EE16 for ; Wed, 15 Dec 2021 13:25:24 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="226083265" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="226083265" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 05:25:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="465600176" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga006.jf.intel.com with SMTP; 15 Dec 2021 05:25:20 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 15 Dec 2021 15:25:19 +0200 Date: Wed, 15 Dec 2021 15:25:19 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Sarvela, Tomi P" Message-ID: References: <20211213134450.3082-1-ville.syrjala@linux.intel.com> <20211213134450.3082-2-ville.syrjala@linux.intel.com> <871r2g702r.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Dec 15, 2021 at 09:05:03AM +0000, Sarvela, Tomi P wrote: > > From: Ville Syrjälä > > > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: > > > > On Mon, 13 Dec 2021, Ville Syrjala wrote: > > > > > > > > This one is only used in gvt, anyway. And that actually makes me wonder > > > > if this should be breaking the build. Does CI not have gvt enabled? > > > > > > Hmm. I thought it was enabled in CI, but maybe not. I've often broken > > > gvt with register define changes but I've always caught it before > > > pushing. I think I have gvt enabled in my "make sure all commits build > > > before I push" test config, so maybe that's where I caught most of them. > > > > > > Tomi, can we enable gvt in ci builds to make sure it at least still > > > builds? > > > > Actually cc Tomi.. > > GVT-d is enabled and tested by fi-bdw-gvtdvm. We're talking about the other gvt (whatever it was called), ie. CONFIG_DRM_I915_GVT. -- Ville Syrjälä Intel