Re: [Intel-gfx] [PATCH 5/6] drm/i915/bios: Nuke DEVICE_TYPE_DP_DUAL_MODE_BITS

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Dec 22, 2021 at 11:34:47AM +0200, Jani Nikula wrote:
> On Fri, 17 Dec 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Replace the DEVICE_TYPE_DP_DUAL_MODE_BITS stuff with just
> > a DP+HDMI check. The rest of the bits shouldn't really
> > matter anyway.
> >
> > The slight change in behaviour here is that now we do look at
> > the DEVICE_TYPE_NOT_HDMI_OUTPUT bit (via
> > intel_bios_encoder_supports_hdmi()) when we previously ignored it.
> > The one platform we know that has problems with that bit is VLV.
> > But IIRC the problem was always that buggy VBTs basically never
> > set that bit. So that should be OK since all it would do is make
> > all DVI ports look like HDMI ports instead. Also can't imagine
> > there are many VLV machines with actual DVI ports in existence.
> 
> One other thing is dropping the requirement for
> DEVICE_TYPE_DIGITAL_OUTPUT. I don't know if that should be part of
> intel_bios_encoder_supports_{hdmi,dp}(). *shrug*

Windows doesn't seem to look at that, so probably we shouldn't
either.

-- 
Ville Syrjälä
Intel