From: Andi Shyti <andi.shyti@linux.intel.com>
To: "Sundaresan, Sujaritha" <sujaritha.sundaresan@intel.com>
Cc: Abdiel Janulgue <abdiel.janulgue@gmail.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
DRI Devel <dri-devel@lists.freedesktop.org>,
Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files
Date: Wed, 12 Jan 2022 20:46:51 +0200 [thread overview]
Message-ID: <Yd8iG73L08xx7AYc@intel.intel> (raw)
In-Reply-To: <cc9f4f9b-377e-1a59-1acb-fb492e4bb5c8@intel.com>
Hi Sujaritha,
[...]
> > +static ssize_t act_freq_mhz_show(struct device *dev,
> > + struct device_attribute *attr, char *buff)
> Alignment with the initial (
OK
[...]
> > +static INTEL_GT_RPS_SYSFS_ATTR(RP1_freq_mhz, 0444, rps_rp_mhz_show, NULL);
> > +static INTEL_GT_RPS_SYSFS_ATTR(RPn_freq_mhz, 0444, rps_rp_mhz_show, NULL);
> > +
> Multiple blank lines
OK
[...]
> I think the patch should be good to go barring the whitespace/alignment
> checks.
Thank you, will fix those and resend it,
Andi
next prev parent reply other threads:[~2022-01-12 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 12:15 [Intel-gfx] [PATCH 0/2] Introduce multitile support Andi Shyti
2022-01-11 12:15 ` [Intel-gfx] [PATCH 1/2] drm/i915: Prepare for multiple GTs Andi Shyti
2022-01-11 22:50 ` Stimson, Dale B
2022-01-12 18:43 ` Andi Shyti
2022-01-11 12:15 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files Andi Shyti
2022-01-12 17:10 ` Sundaresan, Sujaritha
2022-01-12 18:46 ` Andi Shyti [this message]
2022-01-11 15:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support Patchwork
2022-01-11 15:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-01-11 15:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-11 21:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd8iG73L08xx7AYc@intel.intel \
--to=andi.shyti@linux.intel.com \
--cc=abdiel.janulgue@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.auld@intel.com \
--cc=sujaritha.sundaresan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox