From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01C02C433EF for ; Mon, 10 Jan 2022 17:12:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 578B710E667; Mon, 10 Jan 2022 17:12:52 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B48D10F9BD for ; Mon, 10 Jan 2022 17:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641834771; x=1673370771; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rFpO3idGkMwxHuRUVjKYhHQ355NihZqo1GVyZknlLlY=; b=XerpnPxVQrSLyKIArZ1i6sZsBdg8qOapkGqEfFRXFcuZogU/uoe1dLHC 0IiprrOEUh4JTIYdyRXEgG5BY9uAKf1sunDFs15xUTrLXAQY5RrYkHEyP +V/GyfS26P5kY5mNiXvsmqqz5gfo2WyKr0SpIznLlTfa0rZyyQ4E+ackK x7HGcQVz+0u9xitwWaGg3DRBAmBnfp1OyXfFBF7OCMEr/vOAUS9Fj87U+ 0xTdKy5syo7ONufQ+1QNMmEv9Fe0wRWUdT4RuURA98MSEV7qNaUtqxcma 4t4Q+zzqUZPWtYlzIhofSlJmf17MRn7M4HIoqo0o1d/O4mxpR2wA0VuSj g==; X-IronPort-AV: E=McAfee;i="6200,9189,10222"; a="243469144" X-IronPort-AV: E=Sophos;i="5.88,277,1635231600"; d="scan'208";a="243469144" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 09:11:39 -0800 X-IronPort-AV: E=Sophos;i="5.88,277,1635231600"; d="scan'208";a="528351871" Received: from ryanjor-mobl.amr.corp.intel.com (HELO intel.com) ([10.255.36.174]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 09:11:37 -0800 Date: Mon, 10 Jan 2022 12:11:36 -0500 From: Rodrigo Vivi To: Bjorn Helgaas Message-ID: References: <20220107210516.907834-3-lucas.demarchi@intel.com> <20220108025732.GA443415@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220108025732.GA443415@bhelgaas> Subject: Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org, Dave Hansen , Lucas De Marchi , Ingo Molnar , Bjorn Helgaas , Thomas Gleixner Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Jan 07, 2022 at 08:57:32PM -0600, Bjorn Helgaas wrote: > On Fri, Jan 07, 2022 at 01:05:16PM -0800, Lucas De Marchi wrote: > > early_pci_scan_bus() does a depth-first traversal, possibly calling > > the quirk functions for each device based on vendor, device and class > > from early_qrk table. intel_graphics_quirks() however uses PCI_ANY_ID > > and does additional filtering in the quirk. > > > > If there is an Intel integrated + discrete GPU the quirk may be called > > first for the discrete GPU based on the PCI topology. Then we will fail > > to reserve the system stolen memory for the integrated GPU, because we > > will already have marked the quirk as "applied". > > > > This was reproduced in a setup with Alderlake-P (integrated) + DG2 > > (discrete), with the following PCI topology: > > > > - 00:01.0 Bridge > > `- 03:00.0 DG2 > > - 00:02.0 Integrated GPU > > > > Move the setting of quirk_applied in intel_graphics_quirks() so it's > > mark as applied only when we find the integrated GPU based on the > > intel_early_ids table. > > > > Signed-off-by: Lucas De Marchi > > I don't know the details of stolen memory, but the implementation of > this quirk looks good to me. Very nice that it's now very clear > exactly what the change is. Reviewed-by: Rodrigo Vivi Bjorn, ack to merge through drm-intel? > > > --- > > > > v3: now that we do the refactor before the fix, we can do a single line > > change to fix intel_graphics_quirks(). Also, we don't change > > intel_graphics_stolen() anymore as we did in v2: we don't have to check > > other devices anymore if there was a previous match causing > > intel_graphics_stolen() to be called (there can only be one integrated > > GPU reserving the stolen memory). > > > > arch/x86/kernel/early-quirks.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c > > index df34963e23bf..932f9087c324 100644 > > --- a/arch/x86/kernel/early-quirks.c > > +++ b/arch/x86/kernel/early-quirks.c > > @@ -609,8 +609,6 @@ static void __init intel_graphics_quirks(int num, int slot, int func) > > if (quirk_applied) > > return; > > > > - quirk_applied = true; > > - > > device = read_pci_config_16(num, slot, func, PCI_DEVICE_ID); > > > > for (i = 0; i < ARRAY_SIZE(intel_early_ids); i++) { > > @@ -623,6 +621,8 @@ static void __init intel_graphics_quirks(int num, int slot, int func) > > > > intel_graphics_stolen(num, slot, func, early_ops); > > > > + quirk_applied = true; > > + > > return; > > } > > } > > -- > > 2.34.1 > >