From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 5/5] drm/i915: Move dsc/joiner enable into hsw_crtc_enable()
Date: Tue, 25 Jan 2022 07:59:06 +0200 [thread overview]
Message-ID: <Ye+Rquq9A5WggsYq@intel.com> (raw)
In-Reply-To: <87tuds1ih7.fsf@intel.com>
On Tue, Jan 25, 2022 at 07:40:04AM +0200, Jani Nikula wrote:
> On Mon, 24 Jan 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Lift the dsc/joiner enable up from the wonky places where it
> > currently sits (ddi .pre_enable() or icl_ddi_bigjoiner_pre_enable())
> > into hsw_crtc_enable() where we write the other per-pipe stuff
> > as well. Makes the transcoder vs. pipe split less confusing.
> >
>
> What about the enable call in DSI?
Hrm. Looks safeish to relocate as well. It will reorder things
vs. the transcoder timings setup, but can't really think why
that should matter
I'm actually thinking of reordering these a bit for DP/DHMI
as well. Would let us move the whole hsw_configure_cpu_transcoder()
call into the ddi .pre_enable(). Though MST may get in the way of
that plan :/
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-01-25 5:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 19:26 [Intel-gfx] [PATCH 1/5] drm/i915: Skip dsc readout if the transcoder is disabled Ville Syrjala
2022-01-24 19:26 ` [Intel-gfx] [PATCH 2/5] drm/i915: Simplify intel_dsc_source_support() Ville Syrjala
2022-01-24 19:26 ` [Intel-gfx] [PATCH 3/5] drm/i915: Use per-device debugs for bigjoiner stuff Ville Syrjala
2022-01-24 19:26 ` [Intel-gfx] [PATCH 4/5] drm/i915: Extract hsw_configure_cpu_transcoder() Ville Syrjala
2022-01-25 5:38 ` Jani Nikula
2022-01-24 19:26 ` [Intel-gfx] [PATCH 5/5] drm/i915: Move dsc/joiner enable into hsw_crtc_enable() Ville Syrjala
2022-01-25 5:40 ` Jani Nikula
2022-01-25 5:59 ` Ville Syrjälä [this message]
2022-01-25 6:39 ` [Intel-gfx] [PATCH v2 " Ville Syrjala
2022-01-25 6:50 ` Jani Nikula
2022-01-25 7:07 ` Ville Syrjälä
2022-01-24 23:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Skip dsc readout if the transcoder is disabled Patchwork
2022-01-25 5:36 ` [Intel-gfx] [PATCH 1/5] " Jani Nikula
2022-01-25 5:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] " Patchwork
2022-01-25 8:20 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Skip dsc readout if the transcoder is disabled (rev2) Patchwork
2022-01-26 7:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Skip dsc readout if the transcoder is disabled (rev3) Patchwork
2022-01-26 10:00 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye+Rquq9A5WggsYq@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox