From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E7D5C433FE for ; Tue, 18 Jan 2022 12:49:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F52B10E444; Tue, 18 Jan 2022 12:49:54 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 757AD10E2ED; Tue, 18 Jan 2022 12:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642510192; x=1674046192; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=giH6FUZ+eYqzQs5QEmAZOh2DvzvFkyaYRr2gH21bW7E=; b=JtazJ8P4TDSo9CHHhm4Zirx110xQTnPZGZgVrlSXvDLeAw8xW4FoSRks kSyl6XGKQWSrnPaSgYRpFGOucda4DmfYGKRHpq3AgUa4a5Cwvuq/HtLQv z21LJh+eFbZXgxtteuAc8XAhP77vkkIWQhESGR5XXOtJBGsAhe/H0Rrfx mKiwpd+r6wIu+f1TrSuFMkcMqyZcka01V5V6Wns8t+BYLUGJMhDORfJHk ebjPv2OPzvQ3tsB9tJxTa7byJTebK+OPwo8xovnats/3ydHQrkG2UCMQF H8E0Su3UOCL636mZJXpvOnPPtPJucDZgaj0R4hSX7BHiPiC5j87SiL1Bs g==; X-IronPort-AV: E=McAfee;i="6200,9189,10230"; a="232166485" X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="232166485" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 04:49:51 -0800 X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="517757138" Received: from igosu-mobl1.ger.corp.intel.com (HELO intel.com) ([10.252.44.207]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 04:49:50 -0800 Date: Tue, 18 Jan 2022 14:49:47 +0200 From: Andi Shyti To: Tvrtko Ursulin Message-ID: References: <20220117193255.236599-1-andi.shyti@linux.intel.com> <20220117193255.236599-3-andi.shyti@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX , Lucas De Marchi , DRI Devel , Matthew Auld Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Tvrtko, > > +bool is_object_gt(struct kobject *kobj) > > Not sure if you will need it exported in a later patch but for now it seems > only users are local to this file. it is actually used by sysfs_gt.c and sysfs_gt_pm.c. Thank you, Andi PS. in this v4 I forgot to replace many drm_err() with drm_warn(), will do it properly in the next version.