From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA879C433FE for ; Mon, 7 Mar 2022 11:13:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B62C610F65A; Mon, 7 Mar 2022 11:13:19 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A1EB10EA3B; Sun, 6 Mar 2022 03:21:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1EB81B80C0A; Sun, 6 Mar 2022 03:21:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BDEFC340F3; Sun, 6 Mar 2022 03:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646536912; bh=REVJSPu0LMK0qtybGjVcYKrtnj1nArD7KxhlEeXpL5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FLMwT+NpOuEP0vOHJMxtaQQCN/mZaYJMCmAdZvyES6nO1Jm9Au4J35+ADH3prFkmM ZsC2YEFVN7imDE5s5m8f6PyDIVn26Y6IqFvrL83GF/k/fzjXYe3wb03jR5BRTgcRrr GplpnIQyNciooTCOdLNEMZ4J6FdjftAAzxXYLvLg5JuVN5xalRzaVfVDXNYEjymA2u G39goguDmEepx6hgQ/mKOml4CV+xaHXfjnm/O86YxVDqFDzM3UK9bjFVdOxTUxUeu7 yImes0TPKrEI4GAgeKyN+EY3e+9oLaGDV0HhAbva7R4LTpTZ+3MuNkaM5Do/Q61952 YLB3lWUFpmNpQ== Date: Sun, 6 Mar 2022 05:21:11 +0200 From: Jarkko Sakkinen To: Matthew Wilcox Message-ID: References: <20220306021534.83553-1-jarkko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Mon, 07 Mar 2022 11:13:15 +0000 Subject: Re: [Intel-gfx] [PATCH RFC] mm: Add f_ops->populate() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathaniel McCallum , linux-unionfs@vger.kernel.org, intel-gfx@lists.freedesktop.org, Dave Hansen , linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Reinette Chatre , codalist@coda.cs.cmu.edu, linux-sgx@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, Mar 06, 2022 at 02:57:55AM +0000, Matthew Wilcox wrote: > On Sun, Mar 06, 2022 at 04:15:33AM +0200, Jarkko Sakkinen wrote: > > Sometimes you might want to use MAP_POPULATE to ask a device driver to > > initialize the device memory in some specific manner. SGX driver can use > > this to request more memory by issuing ENCLS[EAUG] x86 opcode for each > > page in the address range. > > > > Add f_ops->populate() with the same parameters as f_ops->mmap() and make > > it conditionally called inside call_mmap(). Update call sites > > accodingly. > > Your device driver has a ->mmap operation. Why does it need another > one? More explanation required here. f_ops->mmap() would require an additional parameter, which results heavy refactoring. struct file_operations has 1125 references in the kernel tree, so I decided to check this way around first. BR, Jarkko