From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BFF3C433F5 for ; Mon, 21 Mar 2022 22:38:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE11610E106; Mon, 21 Mar 2022 22:38:11 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 259BD10E03E; Mon, 21 Mar 2022 22:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647902290; x=1679438290; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=NGivaWeKRY3MksBC8EwXE84CdRJB3qnQz8+tE0sTF7w=; b=V2uKyly29TUd6NiBZrWGoI9vbBqYVpbAZRQ/uouzOEEyT1w4TkNv/lRl rJMWqhcC55qYoYwsk587CZj0kruglwvamOY+XgXrQqPGkotWE8Nlj1uZr YGMbbPRI92J4Yn8fBuJXxJkERGQXglwzP+Fp826pWRTP8ykiPn+OWdBLu 9TxZWRKl/DzxCV4fUo5vk+fut7zUg4zswBMni4uesv/jR98TLZlS6//ei joBjv6qZIVAR0RcpLAsSDibJYWWjUfen7wAmIkanLG4hPPeTld3/NRnEf +ZJwQmVRn7MHOpj6U+nEMPKCaFx0tpXD3fB8HoR/Q1qDcySmHXf9RBtsh g==; X-IronPort-AV: E=McAfee;i="6200,9189,10293"; a="255227096" X-IronPort-AV: E=Sophos;i="5.90,199,1643702400"; d="scan'208";a="255227096" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2022 15:38:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,199,1643702400"; d="scan'208";a="560073382" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.61]) by orsmga008.jf.intel.com with SMTP; 21 Mar 2022 15:37:58 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 22 Mar 2022 00:37:57 +0200 Date: Tue, 22 Mar 2022 00:37:57 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Alex Deucher Message-ID: References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 00/22] drm: Review of mode copies X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko =?iso-8859-1?Q?St=FCbner?= , Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , linux-arm-msm , Alain Volmat , Harry Wentland , Chun-Kuang Hu , Jonas Karlman , Leo Li , Chen Feng , Intel Graphics Development , Abhinav Kumar , Maxime Ripard , Nikola Cornij , John Stultz , linux-arm-kernel , Tomi Valkeinen , freedreno , Sandy Huang , Robert Foss , Philipp Zabel , Alex Deucher , Tian Tao , Jyri Sarha , Laurent Pinchart Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: > On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä > wrote: > > > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > > drm: Add drm_mode_init() > > > drm/bridge: Use drm_mode_copy() > > > drm/imx: Use drm_mode_duplicate() > > > drm/panel: Use drm_mode_duplicate() > > > drm/vc4: Use drm_mode_copy() > > These have been pushed to drm-misc-next. > > > > > drm/amdgpu: Remove pointless on stack mode copies > > > drm/amdgpu: Use drm_mode_init() for on-stack modes > > > drm/amdgpu: Use drm_mode_copy() > > amdgpu ones are reviewed, but I'll leave them for the > > AMD folks to push to whichever tree they prefer. > > I pulled patches 2, 4, 5 into my tree. Thanks. > For 3, I'm happy to have it > land via drm-misc with the rest of the mode_init changes if you'd > prefer. Either way works for me. I don't yet have reviews yet for the other drivers, so I'll proably hold off for a bit more at least. And the i915 patch I'll be merging via drm-intel. > > > drm/radeon: Use drm_mode_copy() > > > drm/gma500: Use drm_mode_copy() > > > drm/tilcdc: Use drm_mode_copy() > > > drm/i915: Use drm_mode_copy() Those are now all in. Which leaves us with these stragglers: > > > drm/hisilicon: Use drm_mode_init() for on-stack modes > > > drm/msm: Nuke weird on stack mode copy > > > drm/msm: Use drm_mode_init() for on-stack modes > > > drm/msm: Use drm_mode_copy() > > > drm/mtk: Use drm_mode_init() for on-stack modes > > > drm/rockchip: Use drm_mode_copy() > > > drm/sti: Use drm_mode_copy() > > > drm: Use drm_mode_init() for on-stack modes > > > drm: Use drm_mode_copy() -- Ville Syrjälä Intel