From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB7E1C433F5 for ; Wed, 23 Mar 2022 16:38:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEA8510E70A; Wed, 23 Mar 2022 16:38:32 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 25B6B10E6EE; Wed, 23 Mar 2022 16:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648053511; x=1679589511; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=oOClUr8v7NIBwjfvJAfwavbRCaNDFI67ZFqAiSYqeNI=; b=oGODEJDhtqsrzhDJoemiDtbCqCN+sXBxMIETBHpBZ+VrtUNe30rw0/V0 za4mkg3JZ/2IxGcMJo5LPjPxgWthwyc6ltRmEFwTtZqRL7eXoLecZ1IDl G0TVaYSvX92TS8EFqokrrXRD77unA5z1SWAx3Ibc+icL5EUj8qTroiY4e T9nnmSl28DlOtR9cXiQsQLAPk4tw66oLJDJUm3Xa1rmkj6NFUGqBkc2N2 SFwJatgWhn+VqxAu5Ca+GTz4ry6IBSsSTL4jEnRe5XuPHOjaHxN7WtiKI IFklGt3fyTW0FayWGaPiPQ4FQhZteqEnGm2rfSXQXVbxzew4bsT2nF6Ju Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10295"; a="283010657" X-IronPort-AV: E=Sophos;i="5.90,204,1643702400"; d="scan'208";a="283010657" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2022 09:38:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,204,1643702400"; d="scan'208";a="515845364" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.61]) by orsmga002.jf.intel.com with SMTP; 23 Mar 2022 09:38:25 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 23 Mar 2022 18:38:25 +0200 Date: Wed, 23 Mar 2022 18:38:25 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [RFC 00/19] drm/edid: overhaul CEA data block iteration X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cooper Chiou , william.tseng@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Drew Davenport Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 22, 2022 at 11:40:29PM +0200, Jani Nikula wrote: > Add iterators for EDID blocks and CEA data blocks, to iterate through > all data blocks across all CEA extensions and CTA blocks in DisplayID > data blocks. Fix all code assuming only one CEA extension. Fix code > assuming CTA blocks contain everything that CEA extensions do. Sprinkle > a bunch of cleanups on top. > > This is completely UNTESTED, didn't even smoke test it. It builds. ;) Despite that it's now Reviewed-by: Ville Syrjälä Left a few minor comments here and there. > > This superseeds parts of [1] and [2]. > > BR, > Jani. > > [1] https://patchwork.freedesktop.org/series/101241/ > [2] https://patchwork.freedesktop.org/patch/msgid/20220321044330.27723-1-cooper.chiou@intel.com > > > Cc: Shawn C Lee > Cc: Cooper Chiou > Cc: william.tseng@intel.com > Cc: ankit.k.nautiyal@intel.com > Cc: ville.syrjala@linux.intel.com > Cc: Drew Davenport > > Jani Nikula (19): > drm/edid: add drm_edid_extension_block_count() and drm_edid_size() > drm: use drm_edid_extension_block_count() and drm_edid_size() > drm/edid: clean up CEA data block tag definitions > drm/edid: add iterator for EDID base and extension blocks > drm/edid: add iterator for CEA data blocks > drm/edid: clean up cea_db_is_*() functions > drm/edid: convert add_cea_modes() to use cea db iter > drm/edid: convert drm_edid_to_speaker_allocation() to use cea db iter > drm/edid: convert drm_edid_to_sad() to use cea db iter > drm/edid: convert drm_detect_hdmi_monitor() to use cea db iter > drm/edid: convert drm_detect_monitor_audio() to use cea db iter > drm/edid: convert drm_parse_cea_ext() to use cea db iter > drm/edid: convert drm_edid_to_eld() to use cea db iter > drm/edid: sunset the old unused cea data block iterators > drm/edid: restore some type safety to cea_db_*() functions > drm/edid: detect basic audio only on CEA extension > drm/edid: detect color formats and CEA revision only on CEA extension > drm/edid: skip CEA extension scan in drm_edid_to_eld() just for CEA > rev > drm/edid: sunset drm_find_cea_extension() > > drivers/gpu/drm/drm_connector.c | 2 +- > drivers/gpu/drm/drm_debugfs.c | 3 +- > drivers/gpu/drm/drm_edid.c | 781 ++++++++++++++++++-------------- > include/drm/drm_edid.h | 2 + > 4 files changed, 455 insertions(+), 333 deletions(-) > > -- > 2.30.2 -- Ville Syrjälä Intel