From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A179C433EF for ; Wed, 23 Mar 2022 19:04:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A992C10E066; Wed, 23 Mar 2022 19:04:41 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A03210E066 for ; Wed, 23 Mar 2022 19:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648062280; x=1679598280; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=mis7uXXyyWnGKv4/iIXOE/5rEoMKZMFwHOYn8CgigHk=; b=nkJ0HwmwAgAmkwcpX6eSsAb+lFFdg4XVRgZGEcFBuqkIVt43AeXwgTFu tnCuMPyu1uBNDsR4CkDYlthlBqzYd7QQ6JPTdsw/LlqIHSw4WagEd0a+8 cRe9ym9bB/JEQo3tSA8oSjxzZu70IpYkqi/3zi07ZVbi+UXNROdFC9UsN rFAbYWTrL96Av58KyOh80otSZwDmgNiCcD6/s/ctMYG7FQCyLeJjZSBwf pgsViHhDNl9pZ3Ms7d9wUXUM9FdKw3z+qrQ0gBMQEi0HSe9k47Qk5oOn5 l5CV58YwNsHAVWVplFVNawnZp2gJuC3mxuY9hAFhYadPKivP8A+Q28xQr w==; X-IronPort-AV: E=McAfee;i="6200,9189,10295"; a="240365306" X-IronPort-AV: E=Sophos;i="5.90,204,1643702400"; d="scan'208";a="240365306" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2022 12:04:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,204,1643702400"; d="scan'208";a="647596627" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.61]) by fmsmga002.fm.intel.com with SMTP; 23 Mar 2022 12:04:37 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 23 Mar 2022 21:04:36 +0200 Date: Wed, 23 Mar 2022 21:04:36 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Uma Shankar Message-ID: References: <20220323184522.1359329-1-uma.shankar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220323184522.1359329-1-uma.shankar@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Extend DP HDR support to hsw+ X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Mar 24, 2022 at 12:15:22AM +0530, Uma Shankar wrote: > HSW+ platforms are able to send out HDR Metadata SDP DIP > packet as GMP. Hence, extending the support for HDR on DP > encoders for the same. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5389 > Cc: Ville Syrjälä > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 9e19165fd175..e10d2c151abf 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -4939,7 +4939,7 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connect > intel_attach_dp_colorspace_property(connector); > } > > - if (IS_GEMINILAKE(dev_priv) || DISPLAY_VER(dev_priv) >= 11) > + if (IS_HASWELL(dev_priv) || DISPLAY_VER(dev_priv) >= 8) CHV does not have this at all, and HSW/BDW don't have it on transcoder EDP. Also if we're going to attach this unconditionally then we should stop attaching it again in the LSPCON init path. Or we should skip this one when LSPCON is present. > drm_object_attach_property(&connector->base, > connector->dev->mode_config.hdr_output_metadata_property, > 0); > -- > 2.25.1 -- Ville Syrjälä Intel