From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 624D7C433EF for ; Tue, 26 Apr 2022 19:08:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E39BB10E48C; Tue, 26 Apr 2022 19:08:11 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF22A10E48C; Tue, 26 Apr 2022 19:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651000091; x=1682536091; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=SlTZkvIJehQCtMOYAWcYJuhfxgwmu1ZTUJlhlyGBqeI=; b=ZWq4azWxbCZ584+5yvqvu+3k5kCG5hc86nF7N3app2OHZQfebZ8yHMLz MfKfY4quOmdbfI7HRu2gDNse9YxawD82NTbeTSCSe9nTWgiJd6vzdhH+r wgZ96Y84NHMc1Gz0eKTyMX0tsP4LGdSTFpsYDKwQKleN0hrTW6HyiBZEI /l7lY5CF2XiYwFsuymrXiOMcM9d3Ifht5u+b963cXvUkFgXkWuoQObrsn kTHUf3FNn87MXIq8JGIgKMqF/RFn9xdNxqIyHL9za7HDZCeBR5Fkq52ZO zIrd0WfewAv24ofgyxFbTKdMOTuQUSmc5Qy0N3DgZWIcZoZnZUtmL21oa g==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="265218213" X-IronPort-AV: E=Sophos;i="5.90,291,1643702400"; d="scan'208";a="265218213" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 12:07:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,291,1643702400"; d="scan'208";a="705189688" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.51]) by fmsmga001.fm.intel.com with SMTP; 26 Apr 2022 12:07:52 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 26 Apr 2022 22:07:51 +0300 Date: Tue, 26 Apr 2022 22:07:51 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 02/19] drm/edid: check for HF-SCDB block X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Apr 14, 2022 at 06:06:45PM +0300, Jani Nikula wrote: > From: Lee Shawn C > > Find HF-SCDB information in CEA extensions block. And retrieve > Max_TMDS_Character_Rate that support by sink device. > > v2: HF-SCDB and HF-VSDBS carry the same SCDS data. Reuse > drm_parse_hdmi_forum_vsdb() to parse this packet. > > Cc: Jani Nikula > Cc: Ville Syrjala > Cc: Ankit Nautiyal > Cc: intel-gfx > Signed-off-by: Lee Shawn C > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 4758e78fad82..32ece9607b94 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3495,6 +3495,7 @@ add_detailed_modes(struct drm_connector *connector, const struct edid *edid, > #define EXT_VIDEO_CAPABILITY_BLOCK 0x00 > #define EXT_VIDEO_DATA_BLOCK_420 0x0E > #define EXT_VIDEO_CAP_BLOCK_Y420CMDB 0x0F > +#define EXT_VIDEO_HF_SCDB_DATA_BLOCK 0x79 > #define EDID_BASIC_AUDIO (1 << 6) > #define EDID_CEA_YCRCB444 (1 << 5) > #define EDID_CEA_YCRCB422 (1 << 4) > @@ -4426,6 +4427,20 @@ static bool cea_db_is_vcdb(const u8 *db) > return true; > } > > +static bool cea_db_is_hdmi_forum_scdb(const u8 *db) > +{ > + if (cea_db_tag(db) != USE_EXTENDED_TAG) > + return false; > + > + if (cea_db_payload_len(db) < 7) > + return false; > + > + if (cea_db_extended_tag(db) != EXT_VIDEO_HF_SCDB_DATA_BLOCK) > + return false; > + > + return true; > +} > + > static bool cea_db_is_y420cmdb(const u8 *db) > { > if (cea_db_tag(db) != USE_EXTENDED_TAG) > @@ -5387,7 +5402,8 @@ static void drm_parse_cea_ext(struct drm_connector *connector, > > if (cea_db_is_hdmi_vsdb(db)) > drm_parse_hdmi_vsdb_video(connector, db); > - if (cea_db_is_hdmi_forum_vsdb(db)) > + if (cea_db_is_hdmi_forum_vsdb(db) || > + cea_db_is_hdmi_forum_scdb(db)) > drm_parse_hdmi_forum_vsdb(connector, db); I'd do a s/parse_hdmi_forum_vsdb/parse_scds/ to keep up with the spec terminology. Reviewed-by: Ville Syrjälä > if (cea_db_is_microsoft_vsdb(db)) > drm_parse_microsoft_vsdb(connector, db); > -- > 2.30.2 -- Ville Syrjälä Intel