From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91D3DC433EF for ; Tue, 24 May 2022 18:38:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DC2110F297; Tue, 24 May 2022 18:38:40 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id C26D710F29C; Tue, 24 May 2022 18:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653417518; x=1684953518; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vqXoGohFa7As1pgA+255AsLu16rf4AhZI8o0H4uEeFE=; b=lQvIdH9Erv5EwSzgrxT/8++WeH6U3xBDG85s0S0PUS/CORh0u51fA0Ch ljDOe67XUQq3YqcShD7JsQ/k9ssQwjTmEklXFzbiS1nDEbhb0S0pLBt0M cJqHa1r/94zYhR0/H25LGRL7v5HBOQT5uOdL79DiZ7kbFRLLnQSB1xWlu q5n1PDEvxWcWD6Mb+vNinZUbpYuN86jTWTGTjXRs52F0sHNF2HQVxXyxX Q5BKYssyPS2yWyfAxOGKUn+E5dObHAoIGzP1dd4LLIiuiMD6JQXBShiLs 908ra5gcqwceTozk1ddV5ulS3cJ5NgP4uxjR6U7zDXCtMr7dglWnM6cza Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="254122975" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="254122975" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 11:38:38 -0700 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="717287855" Received: from iucastil-mobl1.amr.corp.intel.com (HELO msatwood-mobl) ([10.212.91.173]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 11:38:38 -0700 Date: Tue, 24 May 2022 11:38:36 -0700 From: Matt Atwood To: Matt Roper , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Message-ID: References: <20220511060228.1179450-1-matthew.d.roper@intel.com> <20220511060228.1179450-5-matthew.d.roper@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220511060228.1179450-5-matthew.d.roper@intel.com> Subject: Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/pvc: Add new BCS engines to GuC engine list X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, May 10, 2022 at 11:02:27PM -0700, Matt Roper wrote: > Intialize ADS system info to reflect the availablity of new BCS engines > > Original-author: CQ Tang > Cc: Stuart Summers > Cc: John Harrison Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > index 3eabf4cf8eec..bb197610fd5b 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > @@ -457,7 +457,7 @@ static void fill_engine_enable_masks(struct intel_gt *gt, > { > info_map_write(info_map, engine_enabled_masks[GUC_RENDER_CLASS], RCS_MASK(gt)); > info_map_write(info_map, engine_enabled_masks[GUC_COMPUTE_CLASS], CCS_MASK(gt)); > - info_map_write(info_map, engine_enabled_masks[GUC_BLITTER_CLASS], 1); > + info_map_write(info_map, engine_enabled_masks[GUC_BLITTER_CLASS], BCS_MASK(gt)); > info_map_write(info_map, engine_enabled_masks[GUC_VIDEO_CLASS], VDBOX_MASK(gt)); > info_map_write(info_map, engine_enabled_masks[GUC_VIDEOENHANCE_CLASS], VEBOX_MASK(gt)); > } > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 54e9c2a5493d..4b147fd90ec4 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1223,6 +1223,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, > }) > #define RCS_MASK(gt) \ > ENGINE_INSTANCES_MASK(gt, RCS0, I915_MAX_RCS) > +#define BCS_MASK(gt) \ > + ENGINE_INSTANCES_MASK(gt, BCS0, I915_MAX_BCS) > #define VDBOX_MASK(gt) \ > ENGINE_INSTANCES_MASK(gt, VCS0, I915_MAX_VCS) > #define VEBOX_MASK(gt) \ > -- > 2.35.1 >