From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50FE9C433FE for ; Tue, 24 May 2022 18:39:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68A2110FB25; Tue, 24 May 2022 18:39:47 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DD3C10FB11; Tue, 24 May 2022 18:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653417586; x=1684953586; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=z4+AU+AgAsq56H58s1nMlrd/+Owomy2rFeH/iCl1uSM=; b=P+ok4TeOtUW//X+pzg2nn47UEummB+ZtbqfonWTfi5QsqE9Yp+uWuesE jioW3G5qyqvddK0Ch7uMwI6KETVaOxSbgHFODrEd7/A1WU+dh34om9U1X vq4TPHcJo8DkQ/qZEwZc4GEYrkYuCINntW2ZnS7QghHlmTPwZcfiiNyqs S6UVCR5sBTKotLzQ5pUOn28v3sRFsoUy/dZn7ejEd4rBbQW6BIgbY2tEA JaBFGLoPIM4WBkBIwjWYpDFztzB0q8mv1Hy5fBiKAnoNsqq9lxaoNTdXm bSnsWjk7h8znK1bl4gxza40TD9C93T+OfYZul1C6EKgXCjcHvtN59CnWk g==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="253498494" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="253498494" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 11:39:45 -0700 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="717288027" Received: from iucastil-mobl1.amr.corp.intel.com (HELO msatwood-mobl) ([10.212.91.173]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 11:39:45 -0700 Date: Tue, 24 May 2022 11:39:43 -0700 From: Matt Atwood To: Matt Roper , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Message-ID: References: <20220511060228.1179450-1-matthew.d.roper@intel.com> <20220511060228.1179450-6-matthew.d.roper@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220511060228.1179450-6-matthew.d.roper@intel.com> Subject: Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/guc: XEHPSDV and PVC do not use HuC X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, May 10, 2022 at 11:02:28PM -0700, Matt Roper wrote: > From: Daniele Ceraolo Spurio > > Disable HuC loading since it is not used on these platforms. > > Cc: Stuart Summers Reviewed-by: Matt Atwood > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c > index ecf149c5fdb0..55e1eb8f3612 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c > @@ -45,6 +45,10 @@ static void uc_expand_default_options(struct intel_uc *uc) > > /* Default: enable HuC authentication and GuC submission */ > i915->params.enable_guc = ENABLE_GUC_LOAD_HUC | ENABLE_GUC_SUBMISSION; > + > + /* XEHPSDV and PVC do not use HuC */ > + if (IS_XEHPSDV(i915) || IS_PONTEVECCHIO(i915)) > + i915->params.enable_guc &= ~ENABLE_GUC_LOAD_HUC; > } > > /* Reset GuC providing us with fresh state for both GuC and HuC. > -- > 2.35.1 >