From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65A2DC43334 for ; Wed, 15 Jun 2022 19:54:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BB1F9112B20; Wed, 15 Jun 2022 19:54:51 +0000 (UTC) Received: from mailrelay3-1.pub.mailoutpod1-cph3.one.com (mailrelay3-1.pub.mailoutpod1-cph3.one.com [46.30.210.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FD1A112B30 for ; Wed, 15 Jun 2022 19:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=MaORVJKokOiv4uLx1FnFMPqkLfVRdqqApsAsnHPVKkU=; b=gp0iX/TobMwx+0jYKqg4yqip6VuG+pHw7YCtBzf7GkUGbR9vTt3N38kH6jnWDeiFYJ28X8TQ+C9Gi E47RUsvhkW7+OGTwwqLgnVbmGtdZTaTnLZpPq1tdT/6DmzFL+50FvD1bgbKL8z+0D5MdSRjGlTPv+4 t6OtpkIiKgLokNdDyzBQPJJAsm9gSFLYLYIpd9qzUYQirWK0/MiHu2wItQLAxAevj/cikmAvrBoMDF Au/0nubZ3JX3JhxZO8sa9sRxvrIo5ZVjYNYMXHMvlLipXb9g2jRRSxrBTQnNapPgBVgYSD9vxFgEVk CfhGGWvbawqK8traSjeQxUMB+8cDzwA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=MaORVJKokOiv4uLx1FnFMPqkLfVRdqqApsAsnHPVKkU=; b=LC+ZxDn2tbfPh9mmhwJTxanQWbQlDEKDpdkka/LFk0ktmR2J1bFrj/ar3DqKZ5i6MopjzgRC/j7iv QH/WqNDAA== X-HalOne-Cookie: 6658136e901833609fc7fc2b1ebe8cadacd96117 X-HalOne-ID: c4445ebd-ece2-11ec-be78-d0431ea8bb03 Received: from mailproxy1.cst.dirpod4-cph3.one.com (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id c4445ebd-ece2-11ec-be78-d0431ea8bb03; Wed, 15 Jun 2022 19:38:44 +0000 (UTC) Date: Wed, 15 Jun 2022 21:38:42 +0200 From: Sam Ravnborg To: Ville Syrjala Message-ID: References: <20220613200317.11305-1-ville.syrjala@linux.intel.com> <20220613200317.11305-2-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220613200317.11305-2-ville.syrjala@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH 1/8] drm: Drop drm_edid.h from drm_crtc.h X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Ville, On Mon, Jun 13, 2022 at 11:03:10PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_crtc.h has no need for drm_edid.h, so don't include it. > Avoids useless rebuilds of the entire universe when > touching drm_edid.h. > > Quite a few placs do currently depend on drm_edid.h without > actually including it directly. All of those need to be fixed > up. This is a very nice reduction in implicit includes. > > diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c > index 204c869d9fe2..43de2ac8f27e 100644 > --- a/drivers/gpu/drm/arm/malidp_mw.c > +++ b/drivers/gpu/drm/arm/malidp_mw.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include Please maintain the alphabetic order of the includes. This reduces the risk of conflict when we have multiple edits in different parallel commits. > diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c > index 14a058a42854..4f2fd69c4a4e 100644 > --- a/drivers/gpu/drm/imx/imx-ldb.c > +++ b/drivers/gpu/drm/imx/imx-ldb.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include ditto > #include > #include > #include > diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c > index 2b1fdf2cbbce..9a2fa352a433 100644 > --- a/drivers/gpu/drm/imx/imx-tve.c > +++ b/drivers/gpu/drm/imx/imx-tve.c > @@ -19,6 +19,7 @@ > > #include > #include > +#include ditto > #include > #include > #include > diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c > index 63ba2ad84679..5a91a5c82057 100644 > --- a/drivers/gpu/drm/imx/parallel-display.c > +++ b/drivers/gpu/drm/imx/parallel-display.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include ditto > #include > #include > #include > diff --git a/drivers/gpu/drm/vboxvideo/vbox_mode.c b/drivers/gpu/drm/vboxvideo/vbox_mode.c > index 4017b0a621fc..52eaa10712ec 100644 > --- a/drivers/gpu/drm/vboxvideo/vbox_mode.c > +++ b/drivers/gpu/drm/vboxvideo/vbox_mode.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include ditto > #include > #include > #include With the above fixed: Acked-by: Sam Ravnborg