From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D2A5C43334 for ; Thu, 23 Jun 2022 11:14:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E98DC10E10C; Thu, 23 Jun 2022 11:14:04 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 04D4010E10C; Thu, 23 Jun 2022 11:14:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655982844; x=1687518844; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ajFYZAC8MEA43zYcILf89zu5jxIuV92OVh4y+errMgM=; b=UqBUOUfsYgh4l0KJPyekEUgrp5pTVqWFajw/CYTAoI0eGXQzU+BN9rrE jroa1otOgctHS2YO59FVrxE4o7ZeM8mFB2mKuVqa0js/fZ9r6kpZg+eAJ SIkZcR22OUEB728S9YicMP0lPH9G5QOSu/Q9KbTi+BL/FyaMUZkzEIH3D LxvCfeotfpw47reMt3QP7CrKVkjKDa4AOArX1LIO1uzxFpoFpce9fOGJf Qc8KuTzt27WaG6EcPEN3ZccJUXCjKmNyap/938U6YnG8S8g8AcgUWYpz4 67JFJtuVOnc08vIzt8aCtIV33OHTfEzrmP7/ng7TmnQa3FOs0nU7IZ4be Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="306150825" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="306150825" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 04:14:03 -0700 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="834592683" Received: from hazegrou-mobl.ger.corp.intel.com (HELO intel.com) ([10.251.216.121]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 04:13:59 -0700 Date: Thu, 23 Jun 2022 13:13:56 +0200 From: Andi Shyti To: Mauro Carvalho Chehab Message-ID: References: <387b9a8d3e719ad2db4fce56c0bfc0f909fd6df6.1655306128.git.mchehab@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <387b9a8d3e719ad2db4fce56c0bfc0f909fd6df6.1655306128.git.mchehab@kernel.org> Subject: Re: [Intel-gfx] [PATCH 4/6] drm/i915/gt: Only invalidate TLBs exposed to user manipulation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mauro.chehab@linux.intel.com, Thomas =?iso-8859-15?Q?Hellstr=F6m?= , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chris Wilson , Thomas Hellstrom , Rodrigo Vivi , Dave Airlie , stable@vger.kernel.org, intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Mauro, On Wed, Jun 15, 2022 at 04:27:38PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Don't flush TLBs when the buffer is only used in the GGTT under full > control of the kernel, as there's no risk of of concurrent access > and stale access from prefetch. > > We only need to invalidate the TLB if they are accessible by the user. > > Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") > > Signed-off-by: Chris Wilson > Cc: Fei Yang > Cc: Andi Shyti > Cc: stable@vger.kernel.org > Acked-by: Thomas Hellström > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Andi Shyti Thanks, Andi