From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E4DDC43334 for ; Thu, 7 Jul 2022 19:39:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BAC014A12D; Thu, 7 Jul 2022 19:38:58 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C6EE14A195; Thu, 7 Jul 2022 19:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657222737; x=1688758737; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WAXsq/7umGZEXtIHC1TBk7MUCXfpreUdr3ejEKMjVNE=; b=b0Hf8cL4Fll36hVNNw8jzvDjZZVV+x3AQuzOjiFxbYTWrcqJ8dmbKeDW 152bcasAmTQi+l1LBnl+qiHIxXCmIHeLd6cLh855oqF5fOjm3CVutriNx IF/FPCqRYiRAezIv6xNwThrRaD2JNvJ++KTh89L83SNT8dYAVNOz06SBf UR5/ufBDUuEVyEg2yijem+MHbiCm6KEZjbb8pGnWz9XW5s/TJRZN3WtaS 7J+4l0rlmmJf8IBxKT/+blFBdkdK50UlDY7rKoEFpuu/VfCf2uuk5T/Rw cHMUtH6Mhjdd2DciB/bQb8YdZQkh9BIIHrgvVPeS7AexzgsmEliroysCN A==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="272904007" X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="272904007" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 12:38:56 -0700 X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="651265237" Received: from tlonnber-mobl.ger.corp.intel.com (HELO intel.com) ([10.251.208.235]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 12:38:54 -0700 Date: Thu, 7 Jul 2022 21:38:51 +0200 From: Andi Shyti To: "Hellstrom, Thomas" Message-ID: References: <20220701225055.8204-1-niranjana.vishwanathapura@intel.com> <20220701225055.8204-7-niranjana.vishwanathapura@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [RFC 06/10] drm/i915/vm_bind: Add I915_GEM_EXECBUFFER3 ioctl X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Zanoni, Paulo R" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "Auld, Matthew" , "Vetter, Daniel" , "christian.koenig@amd.com" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, > It seems we are duplicating a lot of code from i915_execbuffer.c. Did > you consider yeah... while reading the code I was thinking the same then I see that you made the same comment. Perhaps we need to group commonalities and make common library for execbuf 2 and 3. Andi