From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6762EC6FA82 for ; Wed, 14 Sep 2022 15:35:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA95D10E042; Wed, 14 Sep 2022 15:35:58 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id C11B210E042 for ; Wed, 14 Sep 2022 15:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663169751; x=1694705751; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pazspkx17+4IIeIA6dfujNaPmFS/V0oJR3WpyMdZg0c=; b=iDtU/4DtLnM8Q7Bs6AzvPAdbfQIXiaXg9RTc1eT9oiJFG4cyYQTjjCJz bBEcVYvyah4Cuqjaafqwj8e9oazpr1jiUo6db7W7oCHDF15gWDbNy5itv cENUk+yf9CHtJUQWlA7+URs/rx2EFa73RyHyDlkgigHje8KaGegHh/8Ea xFbrdBPYsGOxa08wpSHYHax0JvEvL7SPdtZ3/j9fVaB18iFUfGCzm16Xj H08uAe72+2FonIesCatfmtdWgReogs32TCmixtrM+i4m0lOpsY9iSA3/C oC/M69x1j53Hat05Z0ZSHBOeiBd3XxUvwVzbkXJgrAKLw/JsUvVBZILmn Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="285500030" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="285500030" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 08:35:49 -0700 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="679097420" Received: from pvasili-mobl3.ger.corp.intel.com (HELO intel.com) ([10.252.57.74]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 08:35:46 -0700 Date: Wed, 14 Sep 2022 17:35:44 +0200 From: Andi Shyti To: "Gupta, Anshuman" Message-ID: References: <20220914141553.16864-1-anshuman.gupta@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH] drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "Auld, Matthew" , "Vivi, Rodrigo" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Anshuman, [...] > > > > + * which really disables the PCIe power savings and leaves the bridge to > > D0 > > > > + * state. > > > > + * Let's disable i915 rpm till we fix all known issue with lmem access in > > D3. > > > > + */ > > > > + .has_runtime_pm = 0, > > > > }; > > > > > > > > static const struct intel_device_info adl_s_info = { @@ -1076,6 > > > > +1096,7 @@ static const struct intel_device_info dg2_info = { > > > > XE_LPD_FEATURES, > > > > .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | > > BIT(TRANSCODER_B) | > > > > BIT(TRANSCODER_C) | BIT(TRANSCODER_D), > > > > + .has_runtime_pm = 0, > > > > > > The FIXME msg can be smaller, but it also needs to be here. > > > > I actually like the comment, is very clear and helps understanding the issue :) > Shall I move the comment to commit log , and keep a smaller comment for both DG1 and DG2 ? > With that I can address your comment and Rodrigo comment as well. > Keeping such a big comment at two places will not make any sense. OK for me! Thanks! Andi