From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EC1BC6FA8E for ; Tue, 20 Sep 2022 21:59:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E3B010E080; Tue, 20 Sep 2022 21:59:06 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0000310E080 for ; Tue, 20 Sep 2022 21:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663711143; x=1695247143; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Mu5hdNjHTRtc1O9/r8eh9c3FXmJZDBQCUcLDOvA4CBk=; b=TMvu9lzwKrWY5KY2VhMcpDHt2GxH9DXM4Rt3AFt8gq1SfSMvl0MDTRCl MpMikii5VsYmalmm4ogseigYRCikjdVB8lgh3O2tqwJcxxzwMP76+JFxE OiCEHv/rnvgF93lmb5bamfscBbayMoK2IYdP5KQlzjbT58gnY6AI+9KXY 68U/LhhbJHGm4wfEYJD8Wav0gNB2GqbasC3j4P46WOn2O0YfX58nM1JCe m6cX4UmGnAnO7LCWWecoIKltxw7uc1gAZwstQ4NQBsBPrIy4/ZVSgid0B D2zP3yppmCiuiTK1iI/HL/QvxdnTdvnOajxh2Ri7FIkXBP3/M0IXRX0Q/ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="297423726" X-IronPort-AV: E=Sophos;i="5.93,331,1654585200"; d="scan'208";a="297423726" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 14:59:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,331,1654585200"; d="scan'208";a="722922224" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.191]) by fmsmga002.fm.intel.com with SMTP; 20 Sep 2022 14:59:01 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 21 Sep 2022 00:59:00 +0300 Date: Wed, 21 Sep 2022 00:59:00 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Srivatsa, Anusha" Message-ID: References: <20220917004404.414981-1-anusha.srivatsa@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 0/6] Introduce struct cdclk_step X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "Vivi, Rodrigo" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Sep 20, 2022 at 06:48:46PM +0000, Srivatsa, Anusha wrote: > > > > -----Original Message----- > > From: Ville Syrjälä > > Sent: Tuesday, September 20, 2022 1:20 AM > > To: Srivatsa, Anusha > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > > ; Vivi, Rodrigo > > Subject: Re: [PATCH 0/6] Introduce struct cdclk_step > > > > On Fri, Sep 16, 2022 at 05:43:58PM -0700, Anusha Srivatsa wrote: > > > This is a prep series for the actual cdclk refactoring that will be > > > sent following this. Idea is to have a struct - cdclk_step that holds > > > the following: > > > - cdclk action (squash, crawl or modeset) > > > - cdclk frequency > > > which gets populated in atomic check. Driver uses the populated values > > > during atomic commit to do the suitable sequence of actions like > > > programming squash ctl registers in case of squashing or PLL sequence > > > incase of modeset and so on. > > > > > > This series just addresses the initial idea. The actual plumming in > > > the atomic commit phase will be sent shortly. > > > > OK, people keep ignoring what I say so I just typed up the code quickly. This > > to me seems like the most straightforward way to do what we need: > > https://github.com/vsyrjala/linux.git cdclk_crawl_and_squash > > > > Totally untested ofc, apart from me doing a quick scan through our cdclk > > tables for the crawl+squahs platforms to make sure that this approach > > should produce sane values. > Ville, > Why have a mid cdclk_config? Cant we use the new-cdclk-config for this purpose? You either - start at old, crawl to mid, then squash to new - start at old, squash to mid, then crawl to new -- Ville Syrjälä Intel