From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 896FDC6FA86 for ; Thu, 22 Sep 2022 09:43:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D91A10E26B; Thu, 22 Sep 2022 09:43:16 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0A3C10E14B for ; Thu, 22 Sep 2022 09:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663839792; x=1695375792; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=utDcrjrktkWZhqChRwWXqTMyRuJn4Ni4iGUia2Jc4A8=; b=YmyUVuut1SRJPQ0CL/GzIoxzgcD1oRm4K4STBVaoEVHty5TKZl5lccgS +m/u6EyXueCO6ClaSZKOHv0L2/z6CgUXl8WPkbjhAPIglgbnWvTkYqnW+ Sp4IK9hInrQgPCe9GmLLi2lLE6xd1+MbnhjMvX90Ql0oREOyeRo3cESdv 9xobD1Y6PZ5KIhFDDMFyvo4FVZGSwV9jIeNyWs3p6Wte+wX7xVHnsXC7u 6pGwFFaaSaKUH3vtYqMYMGca3iyvx/XHlS2d8bhbXuvFaFN04ikaKVUeY RmE4xSnFtDKVFQS0JzBEDJV/4DT9CfuE6Y6OwhM6t8p7t4FOoYxwK91qz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10477"; a="386540836" X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="386540836" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 02:43:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="650453822" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.191]) by orsmga008.jf.intel.com with SMTP; 22 Sep 2022 02:43:09 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 22 Sep 2022 12:43:09 +0300 Date: Thu, 22 Sep 2022 12:43:09 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: <20220916165206.1499-1-ville.syrjala@linux.intel.com> <20220916165206.1499-3-ville.syrjala@linux.intel.com> <9731fffc60162a34b7790bb08792fc55593e4ca2.camel@coelho.fi> <87leqb7px7.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Mark FBC B gone if pipe B is gone X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Sep 22, 2022 at 12:36:46PM +0300, Ville Syrjälä wrote: > On Thu, Sep 22, 2022 at 11:51:16AM +0300, Jani Nikula wrote: > > On Thu, 22 Sep 2022, Ville Syrjälä wrote: > > > On Thu, Sep 22, 2022 at 11:18:55AM +0300, Luca Coelho wrote: > > >> On Fri, 2022-09-16 at 19:52 +0300, Ville Syrjala wrote: > > >> > From: Ville Syrjälä > > >> > > > >> > If pipe B is fused off we also shouldn't have FBC B. > > >> > > > >> > Signed-off-by: Ville Syrjälä > > >> > --- > > >> > drivers/gpu/drm/i915/intel_device_info.c | 1 + > > >> > 1 file changed, 1 insertion(+) > > >> > > > >> > diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c > > >> > index 1434dc33cf49..fbefebc023f1 100644 > > >> > --- a/drivers/gpu/drm/i915/intel_device_info.c > > >> > +++ b/drivers/gpu/drm/i915/intel_device_info.c > > >> > @@ -394,6 +394,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) > > >> > if (dfsm & SKL_DFSM_PIPE_B_DISABLE) { > > >> > runtime->pipe_mask &= ~BIT(PIPE_B); > > >> > runtime->cpu_transcoder_mask &= ~BIT(TRANSCODER_B); > > >> > + runtime->fbc_mask &= ~BIT(INTEL_FBC_B); > > >> > } > > >> > if (dfsm & SKL_DFSM_PIPE_C_DISABLE) { > > >> > runtime->pipe_mask &= ~BIT(PIPE_C); > > >> > > >> I don't know (yet) what exactly this does, but it makes sense if you > > >> think of consistency: we already do that for PIPE_A. > > > > > > It's basically saying the entire pipe is fused off, so anything > > > living inside that pipe should also be fused off. > > > > > >> > > >> But what about PIPE_C and PIPE_D? Wouldn't it make sense to do the same > > >> thing for them as well? > > > > > > There is no FBC engine on those pipes (we don't even have > > > the INTEL_FBC_C+ enum values defined), at least for now. > > > > A future proof way would be to add > > > > runtime->fbc_mask &= runtime->pipe_mask; > > Dunno if I entirely like the extra assumption that the enums match. Well, I guess I already did that partially in eg. skl_fbc_id_for_pipe() though that one does allow for a difference in bias at least. > Also would need to make sure we don't accidentally screw up any > old platforms where FBC is not tied to a specific pipe, but I > guess we should never have pipe A fused off on those w/o > the entire display engine fused off as well. > > > > > after all the fuse handling. Would also fix any misconfiguration in > > i915_pci.c. > > > > > > BR, > > Jani. > > > > > > -- > > Jani Nikula, Intel Open Source Graphics Center > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel