From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2B54C54EE9 for ; Tue, 27 Sep 2022 16:12:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F74010E0D6; Tue, 27 Sep 2022 16:12:01 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8079510E0D6 for ; Tue, 27 Sep 2022 16:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664295115; x=1695831115; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5aTLeraMPqUatualZWBCJzc24B85n3rmCerwrJUVV8E=; b=enOITR6ewp3uBDsV1DhxdM7rqai0P0s8aPmApQggyoiBo+Dd4rzLYOj0 YTL+JZ0ZOBghVi71uH5ooYH2TWsolLGfedNZi0gdQffb8Unp16FvSl48X 8qsCl+Tpt/67vvADFSeDDmNrKSN3DbvjoFpZ/Lcnn0BIp+1ESX2JTGpTE XsUjySTWLxQsRM44tV2FgE0X2NrfnD1L9Z8FenM0LfDVhSL6CGfDjzna7 vU764WSn9mT5m8AUyEQTmv2fsyyZgr80uiX4v8lsbfiMARToaFIVtTtPa l3c3sLwPRvZ4GEVZxNUsV7NfYZ8eHzokfX9ke9XAQyekifCKqKoT/3LQn A==; X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="284484414" X-IronPort-AV: E=Sophos;i="5.93,349,1654585200"; d="scan'208";a="284484414" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 09:11:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="572699696" X-IronPort-AV: E=Sophos;i="5.93,349,1654585200"; d="scan'208";a="572699696" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 27 Sep 2022 09:11:36 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 09:11:36 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 09:11:35 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 27 Sep 2022 09:11:35 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 27 Sep 2022 09:11:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UKrkCIp9s0z0g+RZXZrE2XFMlQE759XjXf/YgtJp8hQjqTAxqg41Xx+NT+iU4myUn1HKY55zt+fRKVh7uFlyGVh0xjUazz69LYk8066imPS/Ey2P8pnxWErjKyPFjL3K/CSnrnNGfl6qqhQKKnxJTzyvl8lFOCWmUHh7ejV8P0wmW2OHTwOiMdw6Q10IwiAE3IGSRcy4KI6Tn6T7OIXmiaQtU5h6PxoS5UglpX1eRtr+zP1Lwj7ymZvA0BbNCLlXrwJxEdn5j9wbnOGhWGB99lxC3V+7FdPsku3Uvclt5sDm1vRGtiCYEy8lmJS14NAKOji0QSlrtolT95qaNHEjAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c+bj4ZbrQuEbTM5DASXuvO41Kx65HrtyGM/ucmzhhUk=; b=nVh0JugoNm5fKIiIef/Ld/8keo21FtwGw5ltIkI+jJMYKIsrq5N3BES80MxYPyS4NqOYcvq7+I86zCmnozPVInAjEgbf+h5btreiwkWz9xuNCxkIvekZd+KoY9jtrv/IsmEKH4qEr5KJ2DbT8RWD/Yqe7SwHb9wpFpLrSOJSqgB1lho36MkD8TpNrEQi5mAk6Y4LuudU07lNsqLykn46i5MkwJIhePOp0rautqRx0+ZdKjphERQvFbLh/N6uUvfeI9KLn+hTjJPt96jv8iRVL24PY8/AwTTBoPQ8OeMDIvAI/0Oz3t/RK4JFvTMdj9wMf4VeUwS7HMCIgirzAsZCWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM6PR11MB2987.namprd11.prod.outlook.com (2603:10b6:5:65::14) by CO1PR11MB4945.namprd11.prod.outlook.com (2603:10b6:303:9c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 16:11:34 +0000 Received: from DM6PR11MB2987.namprd11.prod.outlook.com ([fe80::e918:ab50:e851:612d]) by DM6PR11MB2987.namprd11.prod.outlook.com ([fe80::e918:ab50:e851:612d%7]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 16:11:34 +0000 Date: Tue, 27 Sep 2022 09:11:23 -0700 From: Umesh Nerlige Ramappa To: "Dixit, Ashutosh" Message-ID: References: <20220923201154.283784-1-umesh.nerlige.ramappa@intel.com> <20220923201154.283784-15-umesh.nerlige.ramappa@intel.com> <87y1u6uo32.wl-ashutosh.dixit@intel.com> <53226382-9d11-abdf-e907-a972a8f2e535@intel.com> <8735cd7m1f.wl-ashutosh.dixit@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8735cd7m1f.wl-ashutosh.dixit@intel.com> X-ClientProxiedBy: BYAPR07CA0086.namprd07.prod.outlook.com (2603:10b6:a03:12b::27) To DM6PR11MB2987.namprd11.prod.outlook.com (2603:10b6:5:65::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR11MB2987:EE_|CO1PR11MB4945:EE_ X-MS-Office365-Filtering-Correlation-Id: ffb9c2a9-1303-495d-8e62-08daa0a2f269 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PSYqUnCJMsdDZbIc7vAHqLUY/VN6VeYFcjIp5pRKyW5ITUcXkG91XzQE3IZfOmWUE+Ofr3hlYnOnK44yx/TSoktQsfaHG19byrmcIXcRVhDdYhDQ5Pa4XlSvH3C/HiXGEkCfJEYSHUVn50yDcgMfZ17sn38HfNHshkhLakROm2Yz1MTOZt8Iy2fIqWE1UK+VzLUC70560bW4JtAN7yKwr7fKBFKtmrA0mmVY/lppu90WF0RjK8sbaHyk5eDGboQ2K8+Uk8Py9jmnv4f2bDuA8nxuq34fsoVBZH3OQtF6jounz33WTYXjCKKXVvngj9uoLCUHJgsAsFY1W2/Y90dR0jqIOYee9Su7SA+UqVA1qbGgq9MPZTljJiqm9Bt2r2i+aHhZz1w6i5jj3uHMOFo7+jmk0Dn5/7c5icTAIWno3kHBrIJ3uPzNoBfEZUn+xAYXZ74vwxVD/eT2jUhpb3hrnxivFqtLJPInxVZaLF4mtVq6kYW8mNGOSJ8ImL093klIKTzP7JgJR50kCUVwWxyQ71IN++QDzH1Z1c8m6a2cy8PilEQkF+CqCP+OVjK3YMzH6gHu43pu1A6V9XPO2bFKtPbj/V2e5XjHFtinIFMaeBLDso9lL6luYZgEk9NXbyGGafcMmXMIg+e8WtuPstliZC92iyeFjBRYdxReEzZif11GDQYDY1nipO7Ez2hsMzNGBk+1tpJKZCpLpkEayglAxg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2987.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(7916004)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199015)(9686003)(26005)(6512007)(5660300002)(41300700001)(53546011)(6666004)(8936002)(2906002)(66476007)(66946007)(66556008)(4326008)(6862004)(6506007)(8676002)(38100700002)(33716001)(86362001)(186003)(82960400001)(6636002)(54906003)(316002)(478600001)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTlWRGtPSWtjOFo3dXlzT0UzdXNNMWhJYWVld3lNbDVuaWdiY29ZNzA5dDRk?= =?utf-8?B?MnZNNHZ0L1RBRllTNXIxWHJSa0xKRXJvQnkzWktSRm93QUhPNzI4QjZ2Yy9i?= =?utf-8?B?VjRqc1R2SHZIbHhGUEhFSnd0RkZVdEk0UE5lbmEycTB0aGNEbGhHM3VOdktI?= =?utf-8?B?aDEwQjNHVkhPQUovd3ZUb0tub3hLL1pBbFBUM0FyRFpCMzUxVXNrVTBWTnRN?= =?utf-8?B?Ung2ZzZ1clBucHE0M2NHdlZ5YzZzdWh5cmVmVTVlMloyaGpIeDZrVkxyRmE4?= =?utf-8?B?L08xNHJuNkJRd3psWWUxUTIwV3czbC9sb0k2NnZSMEJ4dkkvTm01aFlkWDJo?= =?utf-8?B?NlNaejJsMVg5aU5ROW1vZkdvTU5WaWVsNkhyOEZIUVhpbThLaWl6dFRyQ2Fu?= =?utf-8?B?YlVNNkFjVkV3RCsxZW1hcHlINXNnc0R3amhUUi9OVkRoQldPMzYyRFBEa0FQ?= =?utf-8?B?d3JzNTJUc1NZZldIemZoc0pVeDc4NytTMEhzSmJXZi9rd3ZPajVFdUorQVlO?= =?utf-8?B?NkRtTUMvclJOSGZYZUQ4Z0ZJb3RZZ3ZSY2hSS2xBUEVjN043QlkyTmNhTnRm?= =?utf-8?B?MTVmeXA3bllJRUR0TnRENkgrVHdRN1ZkZkkvSWlZejcvQzlWTmZOZStxRmF6?= =?utf-8?B?NjJpalZnT0hXelppUFZ2T1N3U3JhVU8yV21DVVROWktGcHdLTDNvbXIrZEJ0?= =?utf-8?B?ZWZkYjcrTU11QXV0dzJ6ZnVCK1dJNHJTWXl5NVQzcFNTSjdwdkx3UjNoZGdP?= =?utf-8?B?bG5lc1FRanlIZlJNUjByS0ZldEE2UG9WZjI2ZUtTSk1iS2NqQ1RtejlONHR2?= =?utf-8?B?TnVoam9CUnJyc2lQZG4yY2RqVTJqaXdrMzFKenU4NklXbHFCLzRxQW9qdHd1?= =?utf-8?B?SjBsTXNRc2wxRVcwUE85clFaL3hjZWRCU3Z3ajdIN3Fpb3Z4bys3QWVFb0Rp?= =?utf-8?B?dEFVVGVUbklHSXd4UHV4U2VkSUtHTldFWkRFYzRIa0hOYi9WUnFwYnl1RzVk?= =?utf-8?B?NEpqRzZ4RklFK1ZlYXlpVjBMZjNFSWcwSmpwVjU5SU5HV29TOUk3YTc1YjJD?= =?utf-8?B?WHVtSHh1YlhSajJtaXIrT2lnMG1YWFhvUFN5QVdNVUR4QlZYdVNXekJrbzc4?= =?utf-8?B?VDVrYWZRVldQQVZMUkJoc0pWbm90dWVqVnlQQzlXeTg5NWgrZGZHWjVsMThu?= =?utf-8?B?ZmNGd01JVDFTeTZWN2g1eG4xUVYxU0VYYkhNYXZ6VUdtUlAzSEhwUTVxT2VP?= =?utf-8?B?aDFqalo5TUhobDNmWjVEOW5CdVd2WHhoNFZCc05VU1liaS9qNi83WjNtMEFz?= =?utf-8?B?cFBQQlVRdEk2bExNenlhTUtiRytaTmxZYkYxeS9oN1p4cUE0SWFEY3ZocDM1?= =?utf-8?B?V2JPc0FZeU9aRkpIOWVlTTUxWlhucU95Q283WXRoRk52OGI2M1RMQ2RnZEFJ?= =?utf-8?B?bkRyaFh2VTU4cFJTZkZrcnVIWG56RVNIclowRCtkMEw4RURVOER4a1hGWDlx?= =?utf-8?B?bjRGNzA5WkdCb25sQzhtbkdzNGRCRXYzUW5oV3VCZzlhS1libzBtWnllejRl?= =?utf-8?B?dmJTSUNiTVlGeG1jRVJZd2ZxbWZlMVlUN2Rud09DYVlvLzNlbitNeWxXY0h0?= =?utf-8?B?K3l5b1cxYXFsYjhQNEg2bmlJekFwalU3cjZ3L2duN21wbERsMnRWY2FPVlRo?= =?utf-8?B?KzBveFFVTjgwZHYxS3VteGduMFFoNWk3UU90M1NWRzQxTlFXOWhyRnVHWEV1?= =?utf-8?B?TnVwQ1pMbXM0NnV0MXRldVZYZzR2eHFRdjZLSVlRdFJ5amJCbE1NWGkvbVBV?= =?utf-8?B?cmZ4Mk1sTk5JdWg5RWxaL2srV2E3akxmdnhRQ1F0WHh3VHJ5SW9zb0tmNUhC?= =?utf-8?B?RjhMSnh0bGs3R0tSc0RXSS9uRWJvcHJyZWtQcm1VTDBlYTFBSWNneUVUTFI3?= =?utf-8?B?STUxcHQ0eUJIc3dQTjJGbGo1UC9sdlFsM2k3dm1Rb2pVSDBFbXh3TGkvdURw?= =?utf-8?B?U2NHVWpBdENjRncwaHE0K2hxWERFNVRDNHYvNnZSeE5hamhFa2NxcENEeGlh?= =?utf-8?B?N2tFekwwM3ozYXM1clU5SnZWdU9zdFFJNnluTE9wRHZKS1BubmlnT00yYkdP?= =?utf-8?B?cmlBUUJzbXFEVWlUSG1Yc2ZkRmlobUxFRkVFUGdOMmM0S1Z3cDBqVWc5R3hV?= =?utf-8?Q?Pf2iett4EazGBLov39wCMFY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ffb9c2a9-1303-495d-8e62-08daa0a2f269 X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2987.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 16:11:34.1621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VGwdYJ4DKBwOZveUJuRcjmuVJH5+NZHs0crabS+QVgWpcp4J9ZE8a+dohQazWoaHOQ5rFtuf6Ma71apM3QsESvrRohIQzHG/K1PcKQ5jqNk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4945 X-OriginatorOrg: intel.com Subject: Re: [Intel-gfx] [PATCH v2 14/15] drm/i915/guc: Support OA when Wa_16011777198 is enabled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Sep 26, 2022 at 04:28:44PM -0700, Dixit, Ashutosh wrote: >On Mon, 26 Sep 2022 14:17:21 -0700, Belgaumkar, Vinay wrote: >> >> >> On 9/26/2022 11:19 AM, Umesh Nerlige Ramappa wrote: >> > On Mon, Sep 26, 2022 at 08:56:01AM -0700, Dixit, Ashutosh wrote: >> >> On Fri, 23 Sep 2022 13:11:53 -0700, Umesh Nerlige Ramappa wrote: >> >>> >> >>> From: Vinay Belgaumkar >> >> >> >> Hi Umesh/Vinay, >> >> >> >>> @@ -3254,6 +3265,24 @@ static int i915_oa_stream_init(struct >> >>> i915_perf_stream *stream, >> >>>     intel_engine_pm_get(stream->engine); >> >>>     intel_uncore_forcewake_get(stream->uncore, FORCEWAKE_ALL); >> >>> >> >>> +    /* >> >>> +     * Wa_16011777198:dg2: GuC resets render as part of the Wa. This >> >>> causes >> >>> +     * OA to lose the configuration state. Prevent this by overriding >> >>> GUCRC >> >>> +     * mode. >> >>> +     */ >> >>> +    if (intel_guc_slpc_is_used(>->uc.guc) && >> >>> +        intel_uc_uses_guc_rc(>->uc) && >> >> >> >> Is this condition above correct? E.g. what happens when: >> >> >> >> a. GuCRC is used but SLPC is not used? >> >> Currently, we have no way to separate out GuC RC and SLPC. Both are on when >> guc submission is enabled/supported. So, the above check is kind of >> redundant anyways. > >That is why I was suggesting changing the if check to an assert or >drm_err. So looks like it will work with or without GuC RC, but if we are >using GuC RC we should be using SLPC. So: > > if (GuC_RC && !SLPC) > drm_err(); I am little confused. What's the ask here? Should I just use one of these conditions? i.e. if (intel_guc_slpc_is_used(>->uc.guc)) ... Thanks, Umesh > >> Thanks, >> >> Vinay. >> >> >> b. GuCRC is not used. Don't we need to disable RC6 in host based RC6 >> >>   control? >> > >> > When using host based rc6, existing OA code is using forcewake and a >> > reference to engine_pm to prevent rc6. Other questions, directing to >> > @Vinay. >> > >> > Thanks, >> > Umesh >> > >> >> >> >> Do we need to worry about these cases? >> >> >> >> Or if we always expect both GuCRC and SLPC to be used on DG2 then I >> >> think >> >> let's get rid of these from the if condition and add a drm_err() if we >> >> see >> >> these not being used and OA is being enabled on DG2? >> >> >> >> Thanks. >> >> -- >> >> Ashutosh >> >> >> >>> + (IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0) || >> >>> +         IS_DG2_GRAPHICS_STEP(gt->i915, G11, STEP_A0, STEP_B0))) { >> >>> +        ret = intel_guc_slpc_override_gucrc_mode(>->uc.guc.slpc, >> >>> +                             SLPC_GUCRC_MODE_GUCRC_NO_RC6); >> >>> +        if (ret) { >> >>> +            drm_dbg(&stream->perf->i915->drm, >> >>> +                "Unable to override gucrc mode\n"); >> >>> +            goto err_config; >> >>> +        } >> >>> +    } >> >>> + >> >>>     ret = alloc_oa_buffer(stream); >> >>>     if (ret) >> >>>         goto err_oa_buf_alloc; >> >>> -- >> >>> 2.25.1 >> >>>