From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCB88C433FE for ; Mon, 3 Oct 2022 20:56:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2456710E4DA; Mon, 3 Oct 2022 20:56:37 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E009F10E406; Mon, 3 Oct 2022 20:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664830593; x=1696366593; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5JFuCp+8Wk4ieboVdzv748y1JMMemmYHxHZf1BsNXxU=; b=JqXienuuhfRoMpg/urMGVEmBQGmJa/75wDCb+s38jP4qmzp4l+lOromx c+O05f0FHJLk2JClN1VrPbXJuthWjn0JLQ37p4cF1+Ns8VS8uFI0KF3es BMiPIjGL+0/aTNBOs9diPicoBft/5o1/DRXojxe8GoiZRzsZ+gbPKxO78 h5u+/ndj5ZGsBmXdiMHU7OTvjczFQ60TCPKnDVObFt+M74JhoiVoNH9dp Y6CogyOYcRQeczV3VdXLDd/Xod6ncXmzpYql9fylzusw6exuPp4mHxohn sL3c3c1abV9osAVnqBgcHggi52sTptMeL8/DJ8u+tGy9aKrUE4bjGCHIq w==; X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="285949073" X-IronPort-AV: E=Sophos;i="5.93,366,1654585200"; d="scan'208";a="285949073" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2022 13:56:10 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="654520246" X-IronPort-AV: E=Sophos;i="5.93,366,1654585200"; d="scan'208";a="654520246" Received: from kbalinsk-mobl1.ger.corp.intel.com (HELO intel.com) ([10.213.7.91]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2022 13:56:08 -0700 Date: Mon, 3 Oct 2022 22:56:05 +0200 From: Andi Shyti To: Badal Nilawar Message-ID: References: <20220927055020.3499420-1-badal.nilawar@intel.com> <20220927055020.3499420-3-badal.nilawar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220927055020.3499420-3-badal.nilawar@intel.com> Subject: Re: [Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Badal, [...] > static void > hwm_get_preregistration_info(struct drm_i915_private *i915) > { > + struct i915_hwmon *hwmon = i915->hwmon; > + > + if (IS_DG1(i915) || IS_DG2(i915)) why not GRAPHICS_VER(i915) >= 12 here? Andi > + hwmon->rg.gt_perf_status = GEN12_RPSTAT1; > + else > + hwmon->rg.gt_perf_status = INVALID_MMIO_REG; > } > > void i915_hwmon_register(struct drm_i915_private *i915) > -- > 2.25.1